bugGNU Octave - Bugs: bug #59649, "movmean" should be...

 
 

bug #59649: "movmean" should be implemented more memory efficiently

Submitted by:  Markus Mützel <mmuetzel>
Submitted on:  Thu 10 Dec 2020 08:28:24 AM UTC  
 
Category:  Octave Function Severity:  1 - Wish
Priority:  3 - Low Item Group:  Performance
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 21 Dec 2020 11:49:45 AM UTC, comment #2: 

@juanpi: You are probably referring to bug #48774 where an implementation of some of the mov* functions in C++ was provided.
I couldn't find a performance comparison (memory footprint and/or evaluation time) between the .m file version we currently have and the C++ implementation there.
Could you please point me to that performance comparison?

Markus Mützel <mmuetzel>
Project Member
Fri 18 Dec 2020 12:48:26 PM UTC, comment #1: 

It is a vectorized algorithm, the sizes used are the minimum to generate all windows in one go.

There is a c++ implementation in the original messages, but it was less performant than the current one.
I guess one could offer an option "low_memory" to choose between iterative or vectorized algorithm.

Juan Pablo Carbajal <juanpi>
Project Member
Thu 10 Dec 2020 08:28:24 AM UTC, original submission:  

The function "movmean" intermittently uses very large arrays for reasonably sized input.
IIUC, Rik suggested in bug #59599 to implement (at least that part of) the function in C++ which could use a loop instead of the large intermittent array without a performance penalty.

Opening a bug report to not forget about that.

Markus Mützel <mmuetzel>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by juanpi (Posted a comment)
  • -email is unavailable- added by mmuetzel (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-12-10 mmuetzel Priority5 - Normal => 3 - Low

    Back to the top


    Powered by Savane 3.5