bugGNU Octave - Bugs: bug #58567, [octave forge] (image) radon does...

 
 

bug #58567: [octave forge] (image) radon does not support logical images

Submitted by:  None
Submitted on:  Sun 14 Jun 2020 06:25:21 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  Avinoam Kalma <avinoam>
Originator Name:  Sarang Chaudhari Originator Email:  -email is unavailable-
Open/Closed:  Closed Release:  other
Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sun 26 Jul 2020 08:39:30 PM UTC, comment #6: 

I have pushed the patch (http://hg.code.sf.net/p/octave/image/rev/d46b7020e78b),
and opened new bug (bug #58832) for iradon

Closing as fixed.

Avinoam Kalma <avinoam>
Project MemberIn charge of this item.
Fri 24 Jul 2020 06:59:42 AM UTC, comment #5: 

I have had a look at Avinoam's patch in comment #4. (Sorry for the delay, I wasn't getting email notifications any more.)

The patch looks fine to me, thanks for preparing it. I would be happy to see it pushed to the "default" branch of the image package, maybe even to "stable" since it hardly changes any code.

@Avinoam: Could you please also have a second look onto "iradon", the inverse function? I want to avoid that this partner function has the very same problem as radon, and if it should have, then fix it simultanously. But I myself could not find this problem in iradon.

(Note: This iradon function also does not have any test at all. It would be nice to add just some basic test like iradon(ones(5)), but that's probably not the topic of this bug report.)

Hartmut <hardy>
Thu 09 Jul 2020 06:39:46 PM UTC, comment #4: 

Please review the attached patch

(file #49452)

Avinoam Kalma <avinoam>
Project MemberIn charge of this item.
Mon 22 Jun 2020 08:16:32 PM UTC, comment #3: 

Thanks @Hartmut.
I will add some relevant BISTs.

Avinoam Kalma <avinoam>
Project MemberIn charge of this item.
Mon 22 Jun 2020 07:34:11 PM UTC, comment #2: 

@Avinoam: Yes, if you can fix it that easily, go for it. But please make sure the the Octave output is reasonalby compatible to the Matlab output. (I do not know how good this compatibility currently is in radon.m. I have only rarely used this function. A few more Matlab compatible unit tests would probably also be a useful improvement here.)

Hartmut <hardy>
Mon 15 Jun 2020 06:29:11 PM UTC, comment #1: 

Thanks for reporting.
The problem is that your image is logical, and radon currently does not support logical images.

As a workaround, you may use radon (double(edgeimage)).

The fix should be simple: line 35

  if (! isnumeric (I) || ndims (I) != 2)

should be changed to:

  if (! isimage (I) || ndims (I) != 2)

If there is no objection (Carne, Hartmut), I will fix this.

Avinoam Kalma <avinoam>
Project MemberIn charge of this item.
Sun 14 Jun 2020 06:25:21 PM UTC, original submission:  

I was trying some iris recognition using an opensource Matlab code on Github. At one step, however, it was not working. It was a call for the radon function. So just before the step I saved the image data in 'savededgeimage.mat'. For some reason, radon function is throwing an error "I must be a MxN numeric matrix at radon line 36 column 5". I didn't find any reference to the radon code hence I am posting this. Also using imshow I had also saved the image I passed to the function (it is attached as 'edgeimage.jpg'). But the resolution is changed for this image, and this image does work with the radon function!!! So I this point I am confused about what the error actually is.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #49452:  radon.diff added by avinoam (2KiB - application/octet-stream)
file #49262:  savededgeimage.mat added by None (24KiB - application/octet-stream)
file #49263:  edgedimage.jpg added by None (37KiB - image/jpeg)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by hardy (Posted a comment)
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by None (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 15 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-26 avinoam StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2020-07-09 avinoam Attached File- => Added radon.diff, #49452
        StatusConfirmed => Patch Submitted
    2020-06-15 avinoam Item GroupUnexpected Error or Warning => Incorrect Result
        StatusNone => Confirmed
        Assigned toNone => avinoam
        Release5.2.0 => other
        Operating SystemMicrosoft Windows => Any
        Summary[octave forge] (image) radon: I must be a MxN numeric matrix => [octave forge] (image) radon does not support logical images
        Carbon-Copy- => Added carandraug
        Carbon-Copy- => Added hardy
    2020-06-14 mtmiller SummarySome error with the radon function in the Image package => [octave forge] (image) radon: I must be a MxN numeric matrix
    2020-06-14 None Attached File- => Added savededgeimage.mat, #49262
        Attached File- => Added edgedimage.jpg, #49263

    Back to the top


    Powered by Savane 3.5