bugGNU Octave - Bugs: bug #58521, uigetdir ignores selected folder

 
 

bug #58521: uigetdir ignores selected folder

Submitted by:  Miloš Petrašinović <mpetrasinovic>
Submitted on:  Sun 07 Jun 2020 12:22:37 PM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Miloš Petrašinović Open/Closed:  Closed
Release:  5.2.0 Operating System:  Microsoft Windows

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 29 Jun 2020 08:29:04 AM UTC, comment #8: 

The bug here is not a hard crash (like the similar one on Mac OS). And I can't tell if there are other circumstances that make it preferable to use the native file dialogs even with this bug here.
Thus, my reasoning was to change the default but to not prevent users from (willingly) choosing the native file dialogs.
If this is not reasonable or I missed something, feel free to change that.

Markus Mützel <mmuetzel>
Project Member
Sun 28 Jun 2020 05:57:17 PM UTC, comment #7: 

Markus, does your patch intend to only set the default to "false" or should native files dialogs be completely avoided on windows?

Torsten Lilge <ttl>
Project Member
Mon 22 Jun 2020 07:44:04 PM UTC, comment #6: 

I pushed a change to disable "Use native file dialogs" by default on Windows here:
https://hg.savannah.gnu.org/hgweb/octave/rev/2de2b2ddd032

Marking as ready for test.

Markus Mützel <mmuetzel>
Project Member
Mon 08 Jun 2020 06:54:48 PM UTC, comment #5: 

Yes, de-selecting "Use native file dialogs" fixes the issue for me too.

Miloš Petrašinović <mpetrasinovic>
Mon 08 Jun 2020 04:37:26 PM UTC, comment #4: 

I can confirm that de-selecting "Use native file dialogs" in the "General" preferences tab fixes the issue here, too.

Changing the default preference for Windows sounds reasonable - unless someone wants to investigate why this is failing with the native file dialogs.

Markus Mützel <mmuetzel>
Project Member
Mon 08 Jun 2020 04:14:07 PM UTC, comment #3: 

Rik: I feel your pain.

It seems to work correctly for me if I deselect the "Use native file dialogs" option in the "General" preferences tab.  Can anyone else confirm that behavior?

However, I believe we decided to default to using the native file dialogs because of some performance issues.  But the bug report I see about that is bug #54607 which is for KDE, not Windows.  So should we change that default for Windows systems?

John W. Eaton <jwe>
Project Administrator
Mon 08 Jun 2020 03:55:07 PM UTC, comment #2: 

Why is supporting Microsoft Windows always such a pain in the ass?

Rik <rik5>
Project Administrator
Sun 07 Jun 2020 01:00:00 PM UTC, comment #1: 

Confirmed on Windows with the GUI only.
It is working as expected on Linux (GUI or CLI) or with the CLI on Windows.

Still present on the default branch.

Markus Mützel <mmuetzel>
Project Member
Sun 07 Jun 2020 12:22:37 PM UTC, original submission:  

If the user, before clicking the Choose button, selects a folder in a dialog box created by uigetdir this folder is ignored (function returns just path of the opened folder).

Miloš Petrašinović <mpetrasinovic>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by mpetrasinovic (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-07-06 rik5 StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2020-06-22 mmuetzel StatusConfirmed => Ready For Test
    2020-06-08 rik5 Carbon-CopyRemoved 72865 => -
    2020-06-07 mmuetzel CategoryOctave Function => GUI
        StatusNone => Confirmed

    Back to the top


    Powered by Savane 3.5