bugGNU Octave - Bugs: bug #56738, Running a multi-line selection in...

 
 

bug #56738: Running a multi-line selection in the editor does not work anymore

Submitter:  Torsten Lilge <ttl>
Submitted:  Fri 09 Aug 2019 07:36:01 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 15 Aug 2019 08:18:04 PM UTC, comment #10: 

Works for me, too, including plotting and graphics_toolkit.
Closing the report

Torsten Lilge <ttl>
Group Member
Thu 15 Aug 2019 05:14:38 PM UTC, comment #9: 

Original bug is solved on my Windows box after 64289bf338da.
graphics_toolkit & interactive plotting also work.

Philip Nienhuis <philipnienhuis>
Group Member
Wed 14 Aug 2019 04:29:01 AM UTC, comment #8: 

This works for me too...

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Wed 14 Aug 2019 04:22:37 AM UTC, comment #7: 

Here is another attempt:

  http://hg.savannah.gnu.org/hgweb/octave/rev/64289bf338da

Now graphics and running selections from the editor appear to work for me.

John W. Eaton <jwe>
Group administrator
Wed 14 Aug 2019 03:31:11 AM UTC, comment #6: 

Oops.  Well, that's surprising.  I'll check it out.

John W. Eaton <jwe>
Group administrator
Wed 14 Aug 2019 01:15:08 AM UTC, comment #5: 

Apparently switching graphics toolkit does not work either:


octave:1> graphics_toolkit gnuplot
octave:1> graphics_toolkit
ans = qt
octave:2> graphics_toolkit gnuplot
error: sprintf(118,_): but sprintf has size 0x0 (note: variable 'sprintf' shadows function)
error: called from
    gnuplot_binary at line 60 column 1
    gnuplot_binary at line 60 column 1
    __gnuplot_version__ at line 33 column 22
    __gnuplot_has_feature__ at line 40 column 21
    isfigure at line 86 column 21
    graphics_toolkit at line 63 column 5
    graphics_toolkit at line 1 column 1
    gnuplot_binary at line 1 column 1
    gnuplot_binary at line 60 column 1
    __gnuplot_version__ at line 33 column 22
    __gnuplot_has_feature__ at line 40 column 21
    isfigure at line 86 column 21
    graphics_toolkit at line 63 column 5
octave:2> graphics_toolkit
ans = qt
octave:3>


Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Wed 14 Aug 2019 01:02:36 AM UTC, comment #4: 

That seems to broke interactive plotting for me.
I.e. docs are built fine, but if I start
./run-octave and do say plot(1:10) absolutely nothing happens.
Same with either gnuplot or qt backends...

Also, "help" seems to be broken as well (also, "help help"
just nothing happens).

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Tue 13 Aug 2019 11:24:27 PM UTC, comment #3: 

I pushed the following changeset:

  http://hg.savannah.gnu.org/hgweb/octave/rev/829d9efb7730

It seems to fix the problem for me.

John W. Eaton <jwe>
Group administrator
Mon 12 Aug 2019 07:34:57 PM UTC, comment #2: 

Yes, changeset 420611c61298 is the cause of the problem.  I'm looking at a fix that doesn't require restoring the command queue in the GUI.

John W. Eaton <jwe>
Group administrator
Sat 10 Aug 2019 09:32:41 PM UTC, comment #1: 

I can confirm this on my Win7 box (didn't try on Linux yet although an Octave dist was build there to crossbuild for Windows)

Philip Nienhuis <philipnienhuis>
Group Member
Fri 09 Aug 2019 07:36:01 PM UTC, original submission:  

When running a multi-line selection in the editor, only the last line is really executed. Example:

Runing the selection


a = 1
b = 2
c = 3


from the editor leads to the result in the console window


>> a = 1

c =  3
>> b = 2


Only c = 3 is executed, a and b are still undefined afterwards. The previous commands for a and b were only written into the command line and probably were replaced by the following command before execution. Therefore, b = 2 is restored after c = 3 has been executed.

jwe, could this be a regression from changeset 420611c61298 (eliminating the cmd-classes)? I remember that I have implemented the extra queue of cmd objects in the gui because of similar issues, i.e., dropping command requests from the gui in case of several commands in a sequence.

Torsten Lilge <ttl>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by ttl (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-08-15 ttl StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2019-08-13 jwe StatusConfirmed Ready For Test
    2019-08-10 philipnienhuis StatusNone Confirmed
        Operating SystemGNU/Linux Any

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code