bugGNU Octave - Bugs: bug #56703, winqueryreg does not return...

 
 

bug #56703: winqueryreg does not return correct DWORD data

Submitted by:  John Donoghue <lostbard>
Submitted on:  Wed 31 Jul 2019 04:57:38 PM UTC  
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  John Donoghue <lostbard>
Originator Name:  JohnD Open/Closed:  Closed
Release:  5.1.0 Operating System:  Microsoft Windows

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 17 Sep 2019 08:58:20 PM UTC, comment #5: 

I merged stable to default afterwards so that the development version is also caught up.  Marking as fixed and closing report.

Rik <rik5>
Project Administrator
Tue 17 Sep 2019 08:47:22 PM UTC, comment #4: 

I'd forgotten about this one :)

Pushed: http://hg.savannah.gnu.org/hgweb/octave/rev/6bbbfba55989

John Donoghue <lostbard>
Project MemberIn charge of this item.
Tue 17 Sep 2019 06:43:36 PM UTC, comment #3: 

@John: Reviewed your patch.  It looks good.  Go ahead and commit it to stable.

Rik <rik5>
Project Administrator
Wed 31 Jul 2019 07:46:24 PM UTC, comment #2: 

After patch applied to stable:

> winqueryreg ("HKLM", 'SOFTWARE\Microsoft\Windows NT\CurrentVersion', 'InstallDate')


ans = 1554817635

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 31 Jul 2019 05:05:22 PM UTC, comment #1: 

Not compiled yet, but patch simlar to whats in the windows package:

(file #47281)

John Donoghue <lostbard>
Project MemberIn charge of this item.
Wed 31 Jul 2019 04:57:38 PM UTC, original submission:  

Return  DWORD data from the registry, where that value is more than 255:

For example:

winqueryreg ("HKLM", 'SOFTWARE\Microsoft\Windows NT\CurrentVersion', 'InstallDate')

Actual value using regedit:

1554817635

Using the function in octave 5.1:

ans = 99

using a recently updated windows package in Octave 4.2:

ans =   1.5548e+009

Looking at the code, it seems to be getting the value of the first byte of the read buffer rather than getting as a DWORD.

John Donoghue <lostbard>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #47281:  winquery.patch added by lostbard (915B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-09-17 rik5 StatusPatch Reviewed => Fixed
        Open/ClosedOpen => Closed
    2019-09-17 rik5 StatusPatch Submitted => Patch Reviewed
    2019-07-31 lostbard Attached File- => Added winquery.patch, #47281
        StatusIn Progress => Patch Submitted

    Back to the top


    Powered by Savane 3.5