bugGNU Octave - Bugs: bug #56158, editor file name tabs need...


bug #56158: editor file name tabs need improvement

Submitted by:  eflister <eflister>
Submitted on:  Wed 17 Apr 2019 07:34:03 PM UTC  
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  eflister Open/Closed:  Closed
Release:  5.1.0 Operating System:  Mac OS

Add a New Comment (Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


( Jump to the original submission)

Tue 28 May 2019 11:20:17 PM UTC, comment #13: 

Torsten pushed the patch here https://hg.savannah.gnu.org/hgweb/octave/rev/c2a8365c73fc.  Marking as fixed and closing report.

Rik <rik5>
Project Administrator
Mon 27 May 2019 10:15:28 PM UTC, comment #12: 

I tested the patch on macOS 10.14.5 against the current default, and it looks good: the "close" Xs are back on the editor tabs. This system was one that was missing the Xs before.


Andrew Janke <apjanke>
Mon 27 May 2019 04:53:33 PM UTC, comment #11: 

@Torsten: Seems to be no response.  If the patch doesn't hurt anyone else, maybe you should just apply it?

Rik <rik5>
Project Administrator
Fri 17 May 2019 07:17:34 PM UTC, comment #10: 

@eflister: From https://forum.qt.io/topic/94574/how-to-get-usesscrollbuttons-buttons-to-scroll-tabs-when-it-has-many-tabs-for-mac, it seems that the scroll buttons are not implemented in the macos style. You can try to change the style to "fusion" or "windows" in the preferences dialog (tab "General"). This might also fix the problem with the missing tab close buttons.

Torsten Lilge <ttl>
Project Member
Fri 17 May 2019 07:08:14 PM UTC, comment #9: 

The missing tab close buttons on MacOS is also reported for other software based on qt. There is a workaround using a close button by menas of a style sheet, which is used in the attached patch. This works on my system but I have no possibility to test this on MacOS.

It would be very helpful if someone could test this patch on MacOS, preferably if the reported issue shows up on the target system.

(file #46921)

Torsten Lilge <ttl>
Project Member
Fri 19 Apr 2019 11:34:48 AM UTC, comment #8: 

Changeset http://hg.savannah.gnu.org/hgweb/octave/rev/b38807a23fd2 provides a new preference for the position of editor tabs (top, bottom, left, right).

Torsten Lilge <ttl>
Project Member
Fri 19 Apr 2019 07:29:19 AM UTC, comment #7: 

As for the tab scroll buttons, I just have realized that they were already explicitly enabled even before my patch. Thus my patch won't bring them up on Mac.

@Rik: To me, this overlap looks reasonable. It depends on the side where the tabs are moved out of the visible area. In the first screenshot, it is the right margin and in the second it is the left one.

Torsten Lilge <ttl>
Project Member
Fri 19 Apr 2019 01:46:08 AM UTC, comment #6: 

I can reproduce the missing-X behavior in Octave.app 5.1.0 beta 3, which is built using Homebrew (instead of MacPorts), and is using Qt 5.11.2 (where MacPorts is using Qt 5.12.x).



The weird thing is that Octave.app 4.4.1 was also built against the same Qt 5.11.2, and it doesn't have the issue; it always shows the Xs just fine. This does sound like a Qt glitch to me too, but it doesn't seem like it's a change in Qt itself that made it appear.

I'd be surprised if this were an option that was being set: the little area on the left of the tab where the X appears is still active as a "Close" button if you click it, so it doesn't seem like it's turned off completely. And having the X appear only on the selected tab but not the others is really weird.

No clue what's going on here.

Andrew Janke <apjanke>
Fri 19 Apr 2019 12:28:37 AM UTC, comment #5: 

I verified that the Modified icon is correctly displayed even when the full pathname is displayed.

The close tab 'X' always shows up for me as well.  Perhaps there is a Mac-specific Qt option to throw to guarantee that same behavior.

I notice that if I open a few tabs with the full path displayed, shorten the width of the window so that the tab scrollbars are automatically displayed, and then use the scrollbar buttons to move the tabs, then it is possible for the scrollbar buttons to overlap a tab.  This disappears as soon as I even slightly resize the window.  This appears to be a Qt glitch, but possibly there is a workaround by forcing an update event after the scrollbar button has been pressed.

Attached are two images showing the overlap, and then after a resize, the removal of the overlap.

Rik <rik5>
Project Administrator
Thu 18 Apr 2019 07:58:25 PM UTC, comment #4: 

I have pushed the two changesets

The first one provides a tab icon for modified files instead of the "*". The icon does not disappear even when the tab title is truncated.

The second changeset should ensure the use of scroll buttons in case of many tabs. From the docs it seems that this is not the default on all styles.

Torsten Lilge <ttl>
Project Member
Wed 17 Apr 2019 09:08:08 PM UTC, comment #3: 

Now I see a part of the problem. The modification star disappears (only) when the complete file name is shown.

I have no explanation for the other issues. The dynamic handling of the close buttons and of scrolling the tabs is not done by octave.

Torsten Lilge <ttl>
Project Member
Wed 17 Apr 2019 08:48:34 PM UTC, comment #2: 

i attached a screen shot of what i have on osx.  no scrolling available.  no *'s visible.  X only on current tab.  i installed from macports.

eflister <eflister>
Wed 17 Apr 2019 07:56:46 PM UTC, comment #1: 

Are the tabs scrolled out of the viewable area showing arrows for scrolling them horizontically. This is how tabs are handled on Linux when the space is not sufficient to show them all. The modified * is still shown.

The X button is not removed by octave's code and it is always present on other platforms, also for non-selected tabs. You can also close a tab via its right-clock menu or via middle-click without select the tab in advance.

I will check the possibility of vertically arranged tabs.

Torsten Lilge <ttl>
Project Member
Wed 17 Apr 2019 07:34:03 PM UTC, original submission:  

when showing many long file names (esp if "full path" is chosen), editor tabs omit the "unsaved changes (*)" status.

it should be possible to close a file without switching to it - don't remove the "X" button from unselected tabs.

showing them horizontally does not scale, allow dragging to a vertical resizable dock.

eflister <eflister>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:

Attached Files
file #46795:  tab_scrollbar_overlap.png added by rik5 (30KiB - image/png)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by apjanke (Posted a comment)
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by eflister (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.




    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-05-28 rik5 StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2019-05-17 ttl StatusNone => Patch Submitted
    2019-05-17 ttl Attached File- => Added tab-close-button-macos-v01.patch, #46921
    2019-04-19 rik5 Attached File- => Added tab_scrollbar_overlap.png, #46795
        Attached File- => Added tab_scrollbar_after_resize.png, #46796
    2019-04-17 eflister Attached File- => Added Screen Shot 2019-04-17 at 1.45.38 PM.png, #46790

    Back to the top

    Powered by Savane 3.5