bugGNU Octave - Bugs: bug #56157, Setting breakpoint in non-existent...

 
 

bug #56157: Setting breakpoint in non-existent subfunction now produces obtuse error

Submitter:  Rik <rik5>
Submitted:  Wed 17 Apr 2019 05:52:24 PM UTC
   
 
Category:  Interpreter Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 5.1.0 Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 12 Jun 2019 05:07:15 PM UTC, comment #3: 

Aah, thanks.  It works again.  Since this was a regression between 4.4.1 and 5.1.0 I also backported it to stable.

Marking as fixed and closing report.

Rik <rik5>
Group administrator
Wed 12 Jun 2019 01:49:54 PM UTC, comment #2: 

Rik:  Thanks for finding the error.  I pushed the following changeset:

http://hg.savannah.gnu.org/hgweb/octave/rev/f3450193272d

John W. Eaton <jwe>
Group administrator
Wed 12 Jun 2019 04:58:59 AM UTC, comment #1: 

The problem is in tree_evaluator::get_user_code at the end of the function.  These lines are the problem. 

-verbatim-
        fcn = user_code->find_subfunction (subfuns);

        user_code = fcn.user_code_value ();


In the example given, subfuns contains "foo" as it should.  But find_subfunction() returns a nil_rep.  The next line then fails.

Rik <rik5>
Group administrator
Wed 17 Apr 2019 05:52:24 PM UTC, original submission:  

To reproduce the problem use the attached goo.m


function goo
   hoo() ;
endfunction

function hoo
   disp('hoo') ;
endfunction


In Octave 4.4.1,


dbstop goo>foo
error: add_breakpoint: unable to find function 'goo>foo'


In Octave 5.1.0 (and devel branch)


dbstop goo>foo
error: octave_base_value::user_code_value(): wrong type argument '<unknown type>'




Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46787:  goo.m added by rik5 (79B - text/x-matlab)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by rik5
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-06-12 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2019-06-12 jwe StatusConfirmed Ready For Test
    2019-06-12 rik5 Carbon-Copy- Added jwe
    2019-04-17 rik5 Attached File- Added goo.m, #46787

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code