bugGNU Octave - Bugs: bug #55804, [octave forge] (video) Honor...

 
 

bug #55804: [octave forge] (video) Honor CXXFLAGS when building the *.oct files

Submitted by:  Rafael Laboissiere <rlaboiss>
Submitted on:  Fri 01 Mar 2019 05:04:27 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Patch Submitted Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  other Operating System:  GNU/Linux

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 01 Mar 2019 06:22:21 PM UTC, comment #1:

The addition of 'AC_SUBST(CXXFLAGS)' to configure.ac is redundant because it is already AC_SUBST'd automatically by AC_PROG_CXX. But it's fine if the maintainer wants it to be explicit.

'AC_SUBST(CPPFLAGS)' is also builtin and could be removed.

Confirmed that if 'configure' is called with CXXFLAGS in the environment, those options are not passed on to the Makefile, and this patch looks like it does the right thing.

Mike Miller <mtmiller>
Project Administrator
Fri 01 Mar 2019 05:04:27 PM UTC, original submission:

In the video package, src/Makefile ignores the environment variable CXXFLAGS. This precludes the inclusion of user- or system-defined flags, for instance, the hardening flags when building a Debian package. The patch attached to this bug reports fixes the problem.

Rafael Laboissiere <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46385:  use-cxxflags.patch added by rlaboiss (920B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-01 mtmiller StatusNone => Patch Submitted
    2019-03-01 rlaboiss Attached File- => Added use-cxxflags.patch, #46385

    Back to the top


    Powered by Savane 3.4