bugGNU Octave - Bugs: bug #55283, [octave forge] (linear-algebra)...

 
 

bug #55283: [octave forge] (linear-algebra) build fails: "config.h" not found

Submitted by:  Andrew Janke <apjanke>
Submitted on:  Wed 26 Dec 2018 05:02:34 AM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Patch Submitted Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sun 20 Jan 2019 07:29:21 PM UTC, comment #7: 

Attached is a patch that makes of-linear-algebra compile with MXE Octave.

(file #46046)

Markus M├╝tzel <mmuetzel>
Project Member
Sat 29 Dec 2018 09:00:55 PM UTC, comment #6: 

@JohnD:
see bug #55325

Philip Nienhuis <philipnienhuis>
Project Member
Thu 27 Dec 2018 09:54:30 PM UTC, comment #5: 

My vote is at least a ticket that lists them so they dont get forgotten.

I'm hoping to prepare a new release of windows and few others I maintain for the 5.0.0 release, and will tying to ensure they compile with the current dev octave as of teh release date.

John Donoghue <lostbard>
Project Member
Thu 27 Dec 2018 09:18:47 PM UTC, comment #4: 

A little OT:
With Octave-6.0.0, several OF packages with binary modules won't (cross-)compile anymore due to deprecation of e.g., is_numeric_type (replaced by isnumeric) and such, and namespace changes (like feval => octave::feval). I could adapt the affected OF packages except communications, sparsersb and odepkg, and OF-windows can't be built due to an apparent syntax issue that octave-5.0.0 didn't complain about.
I didn't prepare csets yet (a lot of work that I think lies with the pertinent package maintainers), just adapted the code to get the packages built.

What should I do here? open a bug report for ever single "failing" OF package, or just one bug report for all of them (as there are several common causes)?
Whatever, maybe I'd better wait until after Octave-5.x.x is released. Or am I wrong there?

Philip Nienhuis <philipnienhuis>
Project Member
Thu 27 Dec 2018 01:23:51 PM UTC, comment #3: 

As a for info, I had gone through all the packages in may and reported any that did not compile or noted if they compiled from dev.

http://lists.gnu.org/archive/html/octave-maintainers/2018-05/msg00033.html

An updated one (July):

http://lists.gnu.org/archive/html/octave-maintainers/2018-07/msg00130.html

John Donoghue <lostbard>
Project Member
Thu 27 Dec 2018 01:01:51 PM UTC, comment #2: 

I think most of the patches in mxe should be covered in bug reports or are already applied to the dev repos.

For linear algebra:
https://sourceforge.net/p/octave/linear-algebra/ci/6f1b92de265128e5408f26067192bce213786754/

John Donoghue <lostbard>
Project Member
Wed 26 Dec 2018 12:06:36 PM UTC, comment #1: 

As to OF linear-algebra IMO the entire ./src subdir could be thrown out as all binary functions are already in core Octave.
At least I did this for my own cross-builds for Windows since one or two years, maybe even more.

FYI, in mxe-octave/src there are many patches for several packages that used to include config.h. It may be that for some OF packages there are bug reports about it but I think for many others these fixes were just silently included in mxe-octave.

(adapting title to current conventions)
release => other (OF package)
status => confirmed

Philip Nienhuis <philipnienhuis>
Project Member
Wed 26 Dec 2018 05:02:34 AM UTC, original submission:  

Looks like the linear-algebra forge package is still using the deprecated/removed "config.h" from Octave. I think it needs to be updated to use the new header arrangement.

References:

Install output:

>> pkg install -forge -verbose linear-algebra
mkdir (/var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-NBMpe4)
untar (/Users/janke/linear-algebra-2.2.2.tar.gz, /var/folders/_4/9mx5ryp52bb_z6drbcbrhwl40000gn/T/oct-NBMpe4)
checking for gcc... clang
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether clang accepts -g... yes
checking for clang option to accept ISO C89... none needed
checking for mkoctfile... /Applications/Octave-4.4.0.app/Contents/Resources/usr/Cellar/octave-octave-app_4.4.0/4.4.0/bin/mkoctfile-4.4.0 --verbose
clang++ -std=gnu++11 -c  -fPIC -I/Applications/Octave-4.4.0.app/Contents/Resources/usr/Cellar/octave-octave-app_4.4.0/4.4.0/include/octave-4.4.0/octave/.. -I/Applications/Octave-4.4.0.app/Contents/Resources/usr/Cellar/octave-octave-app_4.4.0/4.4.0/include/octave-4.4.0/octave -I/Applications/Octave-4.4.0.app/Contents/Resources/usr/Cellar/octave-octave-app_4.4.0/4.4.0/include  -D_THREAD_SAFE -pthread -I/Library/Java/JavaVirtualMachines/jdk1.8.0_181.jdk/Contents/Home/include -I/Library/Java/JavaVirtualMachines/jdk1.8.0_181.jdk/Contents/Home/include/darwin -I/Applications/Octave-4.4.0.app/Contents/Resources/usr/opt/sundials27-octave-app_2.7.0/include -I/Applications/Octave-4.4.0.app/Contents/Resources/usr/opt/qscintilla2-octave-app_2.10.4/include    conftest.cc -o conftest.o
conftest.cc:1:10: fatal error: 'octave/config.h' file not found
#include <octave/config.h>
         ^~~~~~~~~~~~~~~~~
1 error generated.
configure: error: Could not run /Applications/Octave-4.4.0.app/Contents/Resources/usr/Cellar/octave-octave-app_4.4.0/4.4.0/bin/mkoctfile-4.4.0 --verbose

pkg: error running the configure script for linear-algebra.
error: called from
    configure_make at line 78 column 9
    install at line 184 column 7
    pkg at line 437 column 9
>>

Andrew Janke <apjanke>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #46046:  of-linear-algebra-5-deprecated.patch added by mmuetzel (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by apjanke (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-03-05 mtmiller StatusConfirmed => Patch Submitted
        Releaseother => dev
        Summary[octave-forge] (linear-algebra) build fails: "config.h" not found => [octave forge] (linear-algebra) build fails: "config.h" not found
    2019-01-26 mtmiller Summary[octave-forge](linear-algebra) build fails: "config.h" not found => [octave-forge] (linear-algebra) build fails: "config.h" not found
    2019-01-20 mmuetzel Attached File- => Added of-linear-algebra-5-deprecated.patch, #46046
    2018-12-26 philipnienhuis StatusNone => Confirmed
        Release4.4.0 => other
        Operating SystemMac OS => Any
        SummaryFORGE: linear-algebra: build fails: "config.h" not found => [octave-forge](linear-algebra) build fails: "config.h" not found

    Back to the top


    Powered by Savane 3.5