bugGNU Octave - Bugs: bug #55085, sizechangedfcn not implemented for...

 
 

bug #55085: sizechangedfcn not implemented for uibuttongroup, uipanel

Submitted by:  Rik <rik5>
Submitted on:  Sat 24 Nov 2018 05:55:04 AM UTC  
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 10 Dec 2018 10:39:34 PM UTC, comment #2:

The patch looks good. I checked in your changeset here (https://hg.savannah.gnu.org/hgweb/octave/rev/4f1b3651fa5f).

I don't think we need to add a warning, but I did document the "resizefcn" property as being deprecated. I also added documentation for the "sizechangedfcn" in the same cset. See https://hg.savannah.gnu.org/hgweb/octave/rev/a5094f65012c.

Rik <rik5>
Project Administrator
Sat 08 Dec 2018 03:31:24 PM UTC, comment #1:

The attached patch adds support for the "sizechangedfcn" property to uipanel and uibuttongroup.

You were right Rik: It was mainly copying the existing code.

I also added support for the "resizefcn" property. Albeit it being deprecated in Matlab since many years, it is still supported afaik.
Removing it from Octave might raise compatibility issues.

Should we add a warning to encourage users to switch to using the "sizechangedfcn" property?

(file #45604)

Markus M├╝tzel <mmuetzel>
Project Member
Sat 24 Nov 2018 05:55:04 AM UTC, original submission:

The three container UI objects figure, uibuttongroup, and uipanel have a "sizechangedfcn" property which holds a handle to a callback function. The property has been implemented for figure objects (see graphics.cc), but not for uibuttongroup and uipanel.

I don't believe it would be particularly hard to add a set_position function for the other two objects which would update the position when changed, and then check for a callback function to execute. As I noted, there is already example code that could be taken from figure::properties::set_position.

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mmuetzel (Updated the item)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-12-10 rik5 StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2018-12-08 mmuetzel StatusNone => Patch Submitted
    2018-12-08 mmuetzel Attached File- => Added bug55085_uipanel_uibuttongroup_sizechangedfcn.patch, #45604

    Back to the top


    Powered by Savane 3.3