bugGNU Octave - Bugs: bug #54982, [octave forge] (optim) optim_doc...

 
 

bug #54982: [octave forge] (optim) optim_doc crashes if exec path contains spaces

Submitter:  None
Submitted:  Wed 07 Nov 2018 09:09:08 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Byron Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 4.4.1
Operating System:  * Microsoft Windows Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sun 25 Jun 2023 09:38:45 AM UTC, comment #9: 
Olaf Till <i7tiol>
Group Member
Fri 13 Jan 2023 01:57:09 PM UTC, comment #8: 

didn't seem to be a problem with this one. Both your submitted function and my patch version are using Unix LF line endings.

Nicholas Jankowski <nrjank>
Group Member
Fri 13 Jan 2023 08:02:11 AM UTC, comment #7: 

Thank you!

Please mind the windows line endings in my file. This sometimes has caused trouble.

Georg Wiora <gwiora>
Wed 11 Jan 2023 05:00:38 PM UTC, comment #6: 

reopened report.  uploaded a version of your patched file turned into a mercurial patch.  marking as patch submitted for the package maintainer to review.

(file #54214)

Nicholas Jankowski <nrjank>
Group Member
Wed 11 Jan 2023 04:43:52 PM UTC, comment #5: 

Please reopen. I think I can provide the missing information: optim_doc fails to open "info" executable on windows system if the executable path contains spaces. You need to quote the file name when submitting it with system command.

In version 1.6.2 of optim package this is in lines 65 an 69 of optim_doc.

This is how line 65 looks with quotes added

    status = system (sprintf ("\"%s\" \"%s\" --index-search \"%s\"", INFO, infopath, keyword));


And this is the same for 69

    status = system (sprintf ("\"%s\" \"%s\"", INFO, infopath));


I have appended the m-file with fixes.


(file #54213)

Georg Wiora <gwiora>
Fri 01 Mar 2019 06:08:51 AM UTC, comment #4: 

No further information from the OP after a few months, closing as works for me. If someone can reproduce and provide the needed information, this can be reopened.

Mike Miller <mtmiller>
Group Member
Thu 15 Nov 2018 03:25:02 PM UTC, comment #3: 

and now the promised attached script ...

(file #45433)

Olaf Till <i7tiol>
Group Member
Thu 15 Nov 2018 03:22:03 PM UTC, comment #2: 

Sorry, how stupid of me, you already indicated your operating system and Octave version. But please still provide the information the testscript would display, and the information on at which command the crash happens. The version of your info program is probably important. I don't know what on Windows is a 'normal terminal', though.

Olaf Till <i7tiol>
Group Member
Thu 15 Nov 2018 03:14:16 PM UTC, comment #1: 

I can't reproduce this, you'd need to provide more information. E.g. you can run the attached testscript (after you have checked that it doesn't contain malicious commands) by copying it into your current directory and typing 'infotest' from the Octave command window.

The script prints information by and by and pauses after each item until a key is pressed. At some point, the crash may happen. You should report the information displayed up to then.

If the crash should prevent displaying the version of your info program, you can type the displayed name of your info program in a normal terminal with the option '--version', e.g. 'info --version', and report this result, too.

Don't forget to tell us your operating system and how you installed Octave.

Olaf Till <i7tiol>
Group Member
Wed 07 Nov 2018 09:09:08 PM UTC, original submission:  

pkg load optim
optim_doc()
seems to crash the Command window of the GUI.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #54214:  optim_doc_crashfix_bug54982.diff added by nrjank (1KiB - application/octet-stream - patch of georg's bugfix)
file #54213:  optim_doc.m added by gwiora (3KiB - application/octet-stream - Fixed version of optim_doc from optim package v1.6.2)
file #45433:  infotest.m added by i7tiol (1KiB - text/x-objcsrc)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nrjank (Updated the item)
  • -email is unavailable- added by gwiora (Updated the item)
  • -email is unavailable- added by i7tiol (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-06-25 i7tiol StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2023-01-11 nrjank Attached File- Added optim_doc_crashfix_bug54982.diff, #54214
        StatusWorks For Me Patch Submitted
        Open/ClosedClosed Open
        Summary[octave forge] (optim) optim_doc crashes [octave forge] (optim) optim_doc crashes if exec path contains spaces
    2023-01-11 gwiora Attached File- Added optim_doc.m, #54213
    2019-03-01 mtmiller StatusNone Works For Me
        Open/ClosedOpen Closed
        Summaryoptim_doc() crashes [octave forge] (optim) optim_doc crashes
    2018-11-15 i7tiol Attached File- Added infotest.m, #45433

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code