bugGNU Octave - Bugs: bug #54600, edit mfile with an error crashes...

 
 

bug #54600: edit mfile with an error crashes octave

Submitted by:  Marshall <marsian>
Submitted on:  Fri 31 Aug 2018 01:07:36 AM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Segfault, Bus Error, etc.
Status:  Confirmed Assigned to:  None
Originator Name:  Marsian Open/Closed:  Open
Release:  4.4.1 Operating System:  Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Thu 20 Sep 2018 04:50:33 PM UTC, comment #7:

One option would be to just launch the command

with the following drawbacks:

  • not responsive if the worker thread is busy
  • does not find the file if not in the current path but in the directory of the currently edited file or in a "private" subdirectory

However, the "edit" command actually opens a file with syntax error but still detects built in functions. In "edit", the method "exist" is used. I will have a look whether this can be used here, too.

Torsten <ttl>
Project Member
Thu 20 Sep 2018 04:07:07 PM UTC, comment #6:

In any case, the short term fix for this looks to be doing "something" to avoid the crash. That still means that when the user right-clicks and chooses "Edit this_function", it will fail. Is there some other function we can call that can find the file without relying on the contents of the file being valid?

Mike Miller <mtmiller>
Project Administrator
Thu 20 Sep 2018 04:00:47 PM UTC, comment #5:

I see, you think the crash may be caused by a multi-threading issue in the symbol table routines. It seems that this kind of thing is coming up more and more, maybe we need to spend some effort making the symbol and path interpreter functions thread-safe.

I originally read this as just an uncaught exception causing a crash, since all errors are exceptions now, but I haven't looked at the stack trace.

Mike Miller <mtmiller>
Project Administrator
Thu 20 Sep 2018 03:57:10 PM UTC, comment #4:

I am going to test this approach. Although it may fix the bug, it does not really fix the cause for the crash.

As far as I have tested, the crash happens because F__which__ is called from the gui thread and not from the worker thread. So I am currently working on a method for calling F__which__ from the worker thread and passing the results to the gui thread. However, this might block the gui thread if the worker thread is already processing a longer computation.

Torsten <ttl>
Project Member
Thu 20 Sep 2018 01:36:18 AM UTC, comment #3:

It looks to me like main_window::handle_edit_mfile_request simply needs a try-catch when it calls '__which__' to catch the exception thrown by the function in case of a parse error or other error.

Mike Miller <mtmiller>
Project Administrator
Fri 14 Sep 2018 08:04:35 PM UTC, comment #2:

For determining the file to edit, F__which__ is used and it seems that

crashes when called with a file containing a parsing error.

Torsten <ttl>
Project Member
Fri 31 Aug 2018 05:03:17 AM UTC, comment #1:

Confirmed on Linux, so chnageing OS to "Any".

Trying to edit files with parsing errors via the editor's (context-)menu crashes octave.

Torsten <ttl>
Project Member
Fri 31 Aug 2018 01:07:36 AM UTC, original submission:

I've had this happen on several occasions now, where I create a new function, run it, get an error, then try to open it via the keyboard edit file shortcut (ctl E is the default, but I have changed it...), and then octave immediately crashes. It has been very repeatable.
The shortcut works on files without an error. Typing "edit file..." works without crashing.

Here's an example:
save a file editCrash1.m with
in the editor type editCrash1 somewhere, click on it and type the edit keyboard shortcut (e.g. ctl E). Octave crashes.

2nd example:
save a file editCrash2.m with
in the editor type editCrash2 somewhere, click on it and type the edit keyboard shortcut (e.g. ctl E). Octave crashes.

Marshall <marsian>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by marsian (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-09-20 mtmiller CategoryNone => GUI
    2018-08-31 ttl StatusNone => Confirmed
        Operating SystemMicrosoft Windows => Any

    Back to the top


    Powered by Savane 3.3