bugGNU Octave - Bugs: bug #54598, Octave cancel normal system...

 
 

bug #54598: Octave cancel normal system reboot/shutdown on KDE

Submitter:  Vascom <vascom>
Submitted:  Thu 30 Aug 2018 12:54:10 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Assigned to:  None
Originator Name:  Open/Closed:  * Open
Release:  * 4.4.1 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 25 Sep 2018 07:30:11 PM UTC, comment #8: 

I agree to comment #6, so there is a good chance for a segfault when the gui closes itself while the interpreter has not finished the exit routine. I will have a deeper look into the exit routine.

Torsten Lilge <ttl>
Group Member
Tue 04 Sep 2018 06:26:38 AM UTC, comment #7: 

I use octave release 4.4.1 tarball.

As I see functional of function
void main_window::closeEvent (QCloseEvent *e)
It just cancel close event, then add octave "exit" command and octave close itself after complete all current commands.

In this way removing e->ignore (); string must not cause any segfaults or hangs.

Vascom <vascom>
Mon 03 Sep 2018 06:11:43 PM UTC, comment #6: 

Which version of Octave or hg id did you try with?
I tried again with hg id c756e9a1e776 and it segfaults only occasionally on close. I didn't see the process hanging around after the GUI disappeared as with the other version I tried last week. (I don't re-call the hg id of that version but it was a recent version of the default branch back than.)

However, it always resets the view to only show the "Command Window". So something definitely doesn't work correctly here.

I don't know the start-up and shut-down process of the Octave GUI. But I think the shut-down is deferred to the interpreter. So the GUI mustn't also shut-down itself before the interpreter is done...
Please, somebody correct me if I'm wrong.

Markus Mützel <mmuetzel>
Group administrator
Mon 03 Sep 2018 07:56:52 AM UTC, comment #5: 

It looks very strange that removing e->ignore (); can cause any segfaults and hangs. I don't see them.

Vascom <vascom>
Fri 31 Aug 2018 03:13:37 AM UTC, comment #4: 

May be exist other way to change this behavior?

Vascom <vascom>
Thu 30 Aug 2018 08:16:19 PM UTC, comment #3: 

If we ignored the event, the GUI application would be closed by the event and via the 'exit' of the worker thread. I guess this is causing the segfault.

Here is the close event of the main window in octave:


  void main_window::closeEvent (QCloseEvent *e)
  {
    e->ignore ();
    octave_cmd_exec *cmd = new octave_cmd_exec ("exit");
    m_cmd_queue.add_cmd (cmd);
  }


I do not see what is causing the issue in our case and how we can directly use the solution mentioned in https://github.com/mujx/nheko/issues/353


Torsten Lilge <ttl>
Group Member
Thu 30 Aug 2018 06:29:49 PM UTC, comment #2: 

If I remove that line, Octave segfaults on exiting the GUI or hangs indefinitely.

Markus Mützel <mmuetzel>
Group administrator
Thu 30 Aug 2018 02:16:18 PM UTC, comment #1: 

This can be solved by removing string
e->ignore ();
from file libgui/src/main-window.cc

Vascom <vascom>
Thu 30 Aug 2018 12:54:10 PM UTC, original submission:  

Then octave gui is run and I try reboot or shutdown system from menu it cancelled with message: "exit cancelled by program /usr/libexec/octave/4.4.1/exec/x86_64-redhat-linux-gnu/octave-gui". And octave window close.

Expected behavior
Normal system reboot/shutdown by request.

Steps to reproduce
Just run octave-gui and try reboot system from KDE menu.

I am use Fedora 28 KDE with Qt 5.10.1.

The same problem was with this application and it was succesfully solved https://github.com/mujx/nheko/issues/353

Please correct this problem.

Vascom <vascom>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by mmuetzel (Posted a comment)
  • -email is unavailable- added by vascom (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code