bugGNU Octave - Bugs: bug #54561, dev octave no nonger runs BISTS on...

 
 

bug #54561: dev octave no nonger runs BISTS on @folders

Submitted by:  John Donoghue <lostbard>
Submitted on:  Thu 23 Aug 2018 05:21:41 PM UTC  
 
Category:  Test Suite Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  JohnD Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 28 Aug 2018 12:37:21 PM UTC, comment #6: 

Ignore the too many files issue - that was my fault

This bug is fixed

John Donoghue <lostbard>
Project Member
Tue 28 Aug 2018 12:25:47 PM UTC, comment #5: 

Now it runs the class tests, but has an error now after running the tests where it can not run any other commands any more (not sure if related to the change or something else):

octave:4> ls
error: no such file, '/home/johnd/octave_dev_hg/build/../scripts/miscellaneous/ls.m'

on exiting octave there is a message:
error: ignoring const execution_exception& while preparing to exit
error: writing file '/home/johnd/.octave_hist': Too many open files
error: ignoring const execution_exception& while preparing to exit

John Donoghue <lostbard>
Project Member
Tue 28 Aug 2018 04:29:04 AM UTC, comment #4: 
John W. Eaton <jwe>
Project Administrator
Mon 27 Aug 2018 06:34:30 PM UTC, comment #3: 

OK, I'll fix.

John W. Eaton <jwe>
Project Administrator
Mon 27 Aug 2018 04:16:07 PM UTC, comment #2: 

I was guessing it was it as well, but hadn't gotten around to doing any tests with it.

After running bisect it does come up with the bad revision of:

The first bad revision is:
changeset:   25818:2be7cf62b9ee
parent:      25816:98242f7e8a0b
user:        John W. Eaton <jwe@octave.org>
date:        Mon Aug 20 15:29:53 2018 -0400
summary:     eliminate some nearly duplicate code in _run_test_suite_

Prior to that change, any tests found in class methds of @classfolders were run as part of the test suite, but now no longer do

John Donoghue <lostbard>
Project Member
Sat 25 Aug 2018 05:41:18 PM UTC, comment #1: 

Can you use hg bisect or something similar to locate the problem changeset?  I'm guessing it might be this one

changeset:   25818:2be7cf62b9ee
parent:      25816:98242f7e8a0b
user:        John W. Eaton <jwe@octave.org>
date:        Mon Aug 20 15:29:53 2018 -0400
summary:     eliminate some nearly duplicate code in __run_test_suite__

If it is, then add jwe to the CC list with an explanation.

Rik <rik5>
Project Administrator
Thu 23 Aug 2018 05:21:41 PM UTC, original submission:  

Running dev octave in windows and running a script for testing packages:

_run_test_suite_ (package_dir}, {})

Any tests in @folders of classes now no longer are run.

John Donoghue <lostbard>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by lostbard
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-10-16 lostbard Dependencies- => bugs #54832 is dependent
    2018-08-28 lostbard StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2018-08-28 jwe StatusNone => Ready For Test
    2018-08-27 lostbard Carbon-Copy- => Added jwe

    Back to the top


    Powered by Savane 3.5