bugGNU Octave - Bugs: bug #54487, [octave forge] (optim) optim-1.5.3...

 
 

bug #54487: [octave forge] (optim) optim-1.5.3 build error in mxe-octave

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Fri 10 Aug 2018 12:35:19 PM UTC  
 
Category:  Octave Forge Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  Closed
Release:  dev Operating System:  Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sun 12 Aug 2018 04:58:48 PM UTC, comment #9:

Thanks. <iostream> is now included in src/error-helpers.h in optim, database, parallel, and struct.

Olaf Till <i7tiol>
Project Member
Fri 10 Aug 2018 07:31:00 PM UTC, comment #8:

The optim package version 1.5.2 did not use std::cerr at all, that is the part that was added in 1.5.3.

Mike Miller <mtmiller>
Project Administrator
Fri 10 Aug 2018 07:25:26 PM UTC, comment #7:

JWE's change dates back from early June so that was already for a long time in my dev builds. But yes it looks related :-)

optim-1.5.3 is another story, was the iostream include removed in that version?

Anyway this discussion is moot, we know what the fix should look like.

Philip Nienhuis <philipnienhuis>
Project Member
Fri 10 Aug 2018 05:40:19 PM UTC, comment #6:

and the optim update to 1.5.3 was 3 days ago, which is why you hadn't seen it before

John Donoghue <lostbard>
Project Member
Fri 10 Aug 2018 05:19:20 PM UTC, comment #5:

Maybe this change?

https://hg.savannah.gnu.org/hgweb/octave/rev/cb1606f78f6b

If so, then yes this was intentional.

Mike Miller <mtmiller>
Project Administrator
Fri 10 Aug 2018 05:12:43 PM UTC, comment #4:

On my other build box I have a slightly older mxe-octave setup (~ 4 weeks old) with optim-1.5.2 and there I didn't get this error, not even with last Wednesday's Octave dev tip (I usually only update the Octave dev dist archive for cross-builds).

The error occurred yesterday evening on my laptop where I started a completely new mxe-octave build from scratch.

So, if there was a change I infer it was somewhere in the last few weeks and related to mxe-octave and/or optim-1.5.3.

Philip Nienhuis <philipnienhuis>
Project Member
Fri 10 Aug 2018 05:01:38 PM UTC, comment #3:

Its also the same error with database and dev octave

John Donoghue <lostbard>
Project Member
Fri 10 Aug 2018 04:10:29 PM UTC, comment #2:

I don't know if it's intentional, but if it were me, I would not assume that an Octave header file pulls in any standard headers or other library headers that I may need. If you use standard streams, then you should include iostream always.

Mike Miller <mtmiller>
Project Administrator
Fri 10 Aug 2018 04:03:39 PM UTC, comment #1:

This include used to be pulled in (indirectly) by octave/oct.h.

Is it purposed for Octave not to export the <iostream> include any more, or is it just a passing mistake in dev?

Olaf Till <i7tiol>
Project Member
Fri 10 Aug 2018 12:35:19 PM UTC, original submission:

When cross-building default-octave:

In log/of-optim:

Adding

#include <iostream>

in error-helper.cc makes the build go on. But I don't know if this is a proper fix.

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by i7tiol (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-08-13 mtmiller StatusNone => Fixed
        Open/ClosedOpen => Closed
    2018-08-10 mtmiller Summary(octave-orge)[optim] optim-1.5.3 build error in mxe-octave => [octave forge] (optim) optim-1.5.3 build error in mxe-octave

    Back to the top


    Powered by Savane 3.3