bugGNU Octave - Bugs: bug #54247, [MXE-Octave] Don't warn about...

 
 

bug #54247: [MXE-Octave] Don't warn about missing Java installation when built with --disable-java

Submitter:  Rik <rik5>
Submitted:  Wed 04 Jul 2018 10:34:48 PM UTC
   
 
Category:  Configuration and Build System Severity:  1 - Wish
Priority:  5 - Normal Item Group:  Feature Request
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 05 Jul 2018 06:50:44 PM UTC, comment #2: 

This was easy.  I fixed it and am closing report.

Rik <rik5>
Group administrator
Wed 04 Jul 2018 10:48:20 PM UTC, comment #1: 

Actually, this doesn't look too hard to resolve, although I don't know the exact syntax.

In tools/makeinst-script.sh.in there is the following


Function .onInit
  Call CheckWinVer
  Call CheckCurrVersion
  Call CheckJRE
  InitPluginsDir
FunctionEnd


The only thing that needs to be done is to make "Call CheckJRE" conditional on wether the build was configured with Java.

Since this file is processed by configure to make the file makeinst-script.sh the necessary information is in @ENABLE_JAVA@.  So, in pseudo-code



Function .onInit
  Call CheckWinVer
  Call CheckCurrVersion
  if (@ENABLE_JAVA@)
    Call CheckJRE
  endif
  InitPluginsDir
FunctionEnd



Rik <rik5>
Group administrator
Wed 04 Jul 2018 10:34:48 PM UTC, original submission:  

When cross building with MXE Octave I run configure with '--disable-java'.  However, the NSIS installer that is created still checks that the host PC has a JVM available and throws up a warning message which I specifically have to agree to before installation can continue.

This is a small issue, but MXE already knows that Java isn't needed because I disabled it.  It would be nice if the resulting installer would skip that step.

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-07-05 rik5 StatusConfirmed Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code