bugGNU Octave - Bugs: bug #54223, Add .editorconfig?

 
 

bug #54223: Add .editorconfig?

Submitter:  Andrew Janke <apjanke>
Submitted:  Mon 02 Jul 2018 12:52:39 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 07 Aug 2019 09:09:27 PM UTC, comment #4: 

I committed an updated version of this patch suggestion on the stable branch.

https://hg.savannah.gnu.org/hgweb/octave/rev/640ee0d531d0

I forgot to include the bug number in the commit message.

Mike Miller <mtmiller>
Group Member
Sat 29 Jun 2019 03:42:41 AM UTC, comment #3: 


> Do these additions look right to you?


Yes.

Andrew Janke <apjanke>
Wed 26 Jun 2019 06:31:31 PM UTC, comment #2: 

There was general support for this on the mailing list in July 2018, and no objections. I also support this change, and the patch looks reasonable.

Some small additions that I think make sense for Octave:


[*]
charset = utf-8

[*.{am,mk}]
indent_style = tab


@apjanke Do these additions look right to you?

Mike Miller <mtmiller>
Group Member
Mon 02 Jul 2018 06:30:19 PM UTC, comment #1: 

This is probably an idea you should bring up on the Octave Maintainer's mailing list where it can get more review.  Not everyone looks at the bug tracker.

Rik <rik5>
Group administrator
Mon 02 Jul 2018 12:52:39 AM UTC, original submission:  

What do you think about adding an .editorconfig to enforce code style in editors that support it?

Andrew Janke <apjanke>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #44485:  add-editorconfig.patch added by apjanke (220B - application/octet-stream - adds editorconfig with 2-space indents)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by apjanke (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-08-07 mtmiller StatusPatch Reviewed Fixed
        Open/ClosedOpen Closed
    2019-06-26 mtmiller StatusNone Patch Reviewed
    2018-07-02 apjanke Attached File- Added add-editorconfig.patch, #44485

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code