bugGNU Octave - Bugs: bug #54074, [octave forge] (image) phantom...

 
 

bug #54074: [octave forge] (image) phantom makes "function parameter persistent"

Submitter:  None
Submitted:  Wed 06 Jun 2018 04:28:47 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Rocket Aaron Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 4.4.0
Operating System:  * GNU/Linux Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 08 Jun 2018 06:15:50 PM UTC, comment #4: 


> BTW, when will a new release be published? There seems to be many changes after last release (2.6.2).


There's a bunch of patches that I have started reviewing and wanted to include on the next release.  But you're right that there's many changes already. They should probably be released soon rather than later, even if that means that the other patches will have to go on a later release.

Carnë Draug <carandraug>
Group Member
Fri 08 Jun 2018 05:44:01 PM UTC, comment #3: 

BTW, when will a new release be published? There seems to be many changes after last release (2.6.2).

Anonymous
Fri 08 Jun 2018 03:44:07 PM UTC, comment #2: 

The recommendation in bug #53331 is to assign the persistent variable to another that is returned.  However, it seems that we can drop the use of persistent here.

I pushed http://hg.code.sf.net/p/octave/image/rev/590aa72e3880

Carnë Draug <carandraug>
Group Member
Thu 07 Jun 2018 05:16:52 PM UTC, comment #1: 

Indeed, the word "persistent" should be removed.
Adding package maintainer to CC list.

Avinoam Kalma <avinoam>
Group Member
Wed 06 Jun 2018 04:28:47 PM UTC, original submission:  

When use function "phantom" from image-2.6.2, unexpected error was raised:


>> P = phantom();
error: can't make function parameter tmp persistent
error: called from
    phantom>mod_shepp_logan at line 213 column 3
    phantom at line 111 column 13


According to bug53331 , it seems persistent function parameter was not allowed any more.

Change that function to


function ellipses = mod_shepp_logan ()
  ## Modified version of Shepp & Logan's head phantom, adjusted to improve
  ## contrast.  Taken from Peter Toft PhD thesis, Table B.3
  persistent tmp      = [ 1.0   0.69    0.92     0.0    0.0       0
                         -0.8   0.6624  0.874    0.0   -0.0184    0
                         -0.2   0.11    0.31     0.22   0.0     -18
                         -0.2   0.16    0.41    -0.22   0.0      18
                          0.1   0.21    0.25     0.0    0.35      0
                          0.1   0.046   0.046    0.0    0.1       0
                          0.1   0.046   0.046    0.0   -0.1       0
                          0.1   0.046   0.023   -0.08  -0.605     0
                          0.1   0.023   0.023    0.0   -0.606     0
                          0.1   0.023   0.046    0.06  -0.605     0];
  ellipses = tmp;
endfunction


seems to work, but should it be done just like that?

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Posted a comment)
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by avinoam
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-06-08 carandraug StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2018-06-07 avinoam StatusNone Confirmed
        Carbon-Copy- Added carandraug
        Carbon-Copy- Added hardy
    2018-06-06 mtmiller Carbon-CopyRemoved 80942 -
    2018-06-06 mtmiller Summaryimage package: phantom makes &quot;function parameter persistent&quot; [octave forge] (image) phantom makes "function parameter persistent"

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code