bugGNU Octave - Bugs: bug #53684, update binary function docstring...

 
 

bug #53684: update binary function docstring in data.cc

Submitter:  None
Submitted:  Wed 18 Apr 2018 02:38:38 AM UTC
   
 
Category:  Documentation Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * dev
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 19 Apr 2018 04:56:15 AM UTC, comment #2: 

Thanks for the patch.  I pushed it here (http://hg.savannah.gnu.org/hgweb/octave/rev/172d464b62ea).  Marking as fixed and closing report.

Rik <rik5>
Group administrator
Wed 18 Apr 2018 06:04:38 PM UTC, comment #1: 

This is a documentation fix for the default branch only. On the stable 4.4 branch the documented behavior is still correct, all of the mentioned binary functions can be called with one argument.

Mike Miller <mtmiller>
Group Member
Wed 18 Apr 2018 02:38:38 AM UTC, original submission:  

After bug #53450 and changeset 25267:308a272bbe3c
the associative binary functions (plus, times, mtimes, and, or) now accept at least two arguments,
so their docstring also need to be update.

Possible patch:

diff -u a/libinterp/corefcn/data.cc b/libinterp/corefcn/data.cc
--- a/libinterp/corefcn/data.cc
+++ b/libinterp/corefcn/data.cc
@@ -5937,7 +5937,6 @@
 (@dots{}((@var{x1} + @var{x2}) + @var{x3}) + @dots{})
 @end example

-At least one argument is required.
 @seealso{minus, uplus}
 @end deftypefn */)
 {
@@ -5980,7 +5979,6 @@
 (@dots{}((@var{x1} * @var{x2}) * @var{x3}) * @dots{})
 @end example

-At least one argument is required.
 @seealso{times, plus, minus, rdivide, mrdivide, mldivide, mpower}
 @end deftypefn */)
 {
@@ -6102,7 +6100,6 @@
 (@dots{}((@var{x1} .* @var{x2}) .* @var{x3}) .* @dots{})
 @end example

-At least one argument is required.
 @seealso{mtimes, rdivide}
 @end deftypefn */)
 {
@@ -6167,7 +6164,6 @@
 (@dots{}((@var{x1} & @var{x2}) & @var{x3}) & @dots{})
 @end example

-At least one argument is required.
 @seealso{or, not, xor}
 @end deftypefn */)
 {
@@ -6189,7 +6185,6 @@
 (@dots{}((@var{x1} | @var{x2}) | @var{x3}) | @dots{})
 @end example

-At least one argument is required.
 @seealso{and, not, xor}
 @end deftypefn */)
 {


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-19 rik5 StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code