bugGNU Octave - Bugs: bug #53639, [windows] gui qt help search...

 
 

bug #53639: [windows] gui qt help search forward button is missing icon

Submitted by:  John Donoghue <lostbard>
Submitted on:  Fri 13 Apr 2018 01:42:14 PM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  JohnD Open/Closed:  Closed
Release:  4.3.90 Operating System:  Microsoft Windows

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 13 Apr 2018 07:39:56 PM UTC, comment #9:

This approach worked.  I checked in the cset here http://hg.savannah.gnu.org/hgweb/octave/rev/f9fe8cf64e09.

Closing as fixed.

Rik <rik5>
Project Administrator
Fri 13 Apr 2018 06:13:32 PM UTC, comment #8:

The icons generally change with the desktop theme which is probably why this wasn't spotted on Linux (which was supplying any missing icons from a deep reserve of icons).  On Windows, I guess , we need to provide all of the icons that we use.

And yes, reflecting the icon was a kluge.  The go-down icon directly from Tango has appropriate attention by a graphics designer.

Rik <rik5>
Project Administrator
Fri 13 Apr 2018 05:53:49 PM UTC, comment #7:

Looking at the archive, flipping the icon about a horizontal line would have a different lighted portion than the tango version.  Ha, might confuse people's sense of light source.  In linux, the icons are a plain flat shade, but probably can change with the desktop theme.

Dan Sebald <sebald>
Fri 13 Apr 2018 05:45:47 PM UTC, comment #6:

I'm attaching go-down.png and go-down.svg for your convenience. I downloaded the latest version of the icon theme, verified that the other svg files matched, and used rsvg-convert to create a 128x128 png from go-down.svg.

file #43919)

Mike Miller <mtmiller>
Project Administrator
Fri 13 Apr 2018 05:40:46 PM UTC, comment #5:

I agree.  I'll swap in the tango production icon if this approach works.

Rik <rik5>
Project Administrator
Fri 13 Apr 2018 05:32:51 PM UTC, comment #4:

I think it would be better to get the icon from the original source:

http://tango.freedesktop.org/releases/tango-icon-theme-0.8.90.tar.gz

Inside the archive, the original source files pulled into Octave are under tango-icon-theme-0.8.90/scalable/actions.

Mike Miller <mtmiller>
Project Administrator
Fri 13 Apr 2018 05:21:46 PM UTC, comment #3:

I've made a go-down icon by reflecting the go-up icon across a vertical line.  I have to go through the full MXE build cycle to check if this works.  Stand by.

Rik <rik5>
Project Administrator
Fri 13 Apr 2018 03:39:37 PM UTC, comment #2:

The reason must be that there is no icon in Octave's repository for go-down.xyz:

@linux ~/octave/octave/octave $ ls libgui/*/*/*go-*
libgui/src/icons/go-first.png  libgui/src/icons/go-last.svg
libgui/src/icons/go-first.svg  libgui/src/icons/go-up.png
libgui/src/icons/go-last.png   libgui/src/icons/go-up.svg

The "go-down" icon name is in this list of standard names:

https://specifications.freedesktop.org/icon-naming-spec/latest/ar01s04.html

I suppose on linux the resource_manager::icon ("go-down") routine finds the icon somewhere else on the system.  On Windows, not.

Dan Sebald <sebald>
Fri 13 Apr 2018 03:09:00 PM UTC, comment #1:

Confirmed.  Attached is an image showing the blank button on a Windows XP VM.


Rik <rik5>
Project Administrator
Fri 13 Apr 2018 01:42:14 PM UTC, original submission:

Showing a help page of the online documentation in the gui documentation pane, press ctrl-F and a input search will display below the help page.

There are tow buttons on the right of the input fields, one for serach forward, other other for search backward.

The search forward button is missing on any text or icon.

In linux it appears ok.

John Donoghue <lostbard>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43918:  go-down.png added by mtmiller (6KiB - image/png)
file #43919:  go-down.svg added by mtmiller (8KiB - image/svg+xml)
file #43914:  missing_srch_btn.png added by rik5 (62KiB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by sebald (Posted a comment)
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by lostbard (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-13 rik5 StatusIn Progress => Fixed
        Open/ClosedOpen => Closed
    2018-04-13 mtmiller Attached File- => Added go-down.png, #43918
        Attached File- => Added go-down.svg, #43919
    2018-04-13 rik5 StatusConfirmed => In Progress
    2018-04-13 rik5 Attached File- => Added missing_srch_btn.png, #43914
        StatusNone => Confirmed

    Back to the top


    Powered by Savane 3.4