bugGNU Octave - Bugs: bug #53577, pkg: should not try to create...

 
 

bug #53577: pkg: should not try to create files or directories until actually needed

Submitter:  Mike Miller <mtmiller>
Submitted:  Fri 06 Apr 2018 08:52:01 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 19 Nov 2018 05:13:26 AM UTC, comment #2: 

I went ahead and pushed the patch here: https://hg.savannah.gnu.org/hgweb/octave/rev/7a8f895c8f15.

Marking as fixed and closing report.

Rik <rik5>
Group administrator
Fri 16 Nov 2018 10:00:35 PM UTC, comment #1: 

I've attached a changeset that seems to work.  Marking as "Patch Submitted"

(file #45458)

Rik <rik5>
Group administrator
Fri 06 Apr 2018 08:52:01 PM UTC, original submission:  

The pkg function creates empty directories and files in the user's home directory, or wherever pkg('prefix') and pkg('local_list') are set to, even if they are not needed.

It shouldn't be too hard to defer creating these files and directories until they are actually used by a pkg command. There is no reason for 'pkg prefix /tmp/foo' to actually create the /tmp/foo directory, until a 'pkg install' command is done later.

Similarly, it shouldn't be an immediate error if I try 'pkg prefix /root/octave', it should just store that for the next pkg command. Then when I actually try to install a package in /root/octave, it should error.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #45458:  53577.cset added by rik5 (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Updated the item)
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-11-19 rik5 StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2018-11-16 rik5 Attached File- Added 53577.cset, #45458
        StatusConfirmed Patch Submitted

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code