bugGNU Octave - Bugs: bug #53567, "pkg install...

 
 

bug #53567: "pkg install nonexistent_pkg" leaks an empty directory in /tmp

Submitted by:  Rik <rik5>
Submitted on:  Thu 05 Apr 2018 05:59:27 PM UTC  
 
Category:  Test Suite Severity:  2 - Minor
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 06 Apr 2018 08:43:07 PM UTC, comment #3:

I made an additional change on the stable branch to fix an error that I was seeing with the 'tmp_dir' variable not being defined in the unwind_protect_cleanup.

https://hg.savannah.gnu.org/hgweb/octave/rev/ad6dce96cbca

It's so good that we have pkg.tst on the default branch now or else this might not have been caught.

Mike Miller <mtmiller>
Project Administrator
Fri 06 Apr 2018 12:40:49 AM UTC, comment #2:

I fixed this on the stable branch here (http://hg.savannah.gnu.org/hgweb/octave/rev/0cd7076a97c8). Closing report.

Rik <rik5>
Project Administrator
Thu 05 Apr 2018 06:08:12 PM UTC, comment #1:

Plus, on e.g., Windows there's no such thing as a cron job that cleans up /tmp dirs.

Philip Nienhuis <philipnienhuis>
Project Member
Thu 05 Apr 2018 05:59:27 PM UTC, original submission:

This isn't a big deal, but the following command will leak a directory oct-XXXXXX in TMPDIR.

The host systems cron jobs will probably come along and clean the TMPDIR periodically. Still, it is bad form and we could probably use an unwind_protect block to remove the temporary dir.

Rik <rik5>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-06 rik5 StatusNone => Fixed
        Open/ClosedOpen => Closed
    2018-04-05 rik5 Summarypkg install nonexistent_pkg leaks an empty directory in /tmp => "pkg install nonexistent_pkg" leaks an empty directory in /tmp

    Back to the top


    Powered by Savane 3.4