bugGNU Octave - Bugs: bug #53556, issymmetric can check for...

 
 

bug #53556: issymmetric can check for skew-symmetry in matlab

Submitter:  Marco Caliari <caliari>
Submitted:  Wed 04 Apr 2018 11:26:53 AM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Matlab Compatibility
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 12 Apr 2018 04:12:25 PM UTC, comment #7: 

My bad.  My memory was vague.  The macro I wanted was @tcode for @code sequences which end with a transpose operator.  I had mistakenly thought the name was @acode for code sequences ending in an apostrophe.

I changed that in a final cset:


changeset:   25228:581d3a13d7e2
bookmark:    @
tag:         tip
user:        Rik <rik@octave.org>
date:        Thu Apr 12 09:10:33 2018 -0700
files:       scripts/linear-algebra/ishermitian.m scripts/linear-algebra/issymmetric.m
description:
ishermitian.m, issymmetric.m: Use @tcode macro in docstring (bug #53556).

* ishermitian.m, issymmetric.m: Use @tcode macro in docstring for code
sequences that end with a transpose operator.



Rik <rik5>
Group administrator
Thu 12 Apr 2018 04:04:48 PM UTC, comment #6: 

@Marco: This is worthy of an entry in the NEWS file.  We just hadn't gotten around to moving the old NEWS file into storage as NEWS.4 in the etc/ directory and then creating a new NEWS file.  I did that here (http://hg.savannah.gnu.org/hgweb/octave/rev/ef521f780839).

Rik <rik5>
Group administrator
Thu 12 Apr 2018 04:04:13 PM UTC, comment #5: 

I just pushed a fix that changes @acode to @code.

John W. Eaton <jwe>
Group administrator
Thu 12 Apr 2018 03:52:38 PM UTC, comment #4: 

Rik -- you might have a typo in you diff (@acode --> @code ?),
you could see the buildbots are failing making docs.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Thu 12 Apr 2018 06:38:08 AM UTC, comment #3: 

@Rik: Well done. I'm wondering if a line should be inserted into the NEWS.

Marco Caliari <caliari>
Group Member
Thu 12 Apr 2018 05:00:10 AM UTC, comment #2: 

I overhauled both issymmetric and ishermitian along the lines you suggested.

http://hg.savannah.gnu.org/hgweb/octave/rev/0f98040552de
http://hg.savannah.gnu.org/hgweb/octave/rev/114ad8f22ee6

I found that by using ! any() I could get a significant performance gain over nnz () == 0.

Marking as fixed and closing report.

Rik <rik5>
Group administrator
Wed 04 Apr 2018 11:29:38 AM UTC, comment #1: 

A diff attached. If it is fine, I can apply the equivalent patch to ishermitian.

(file #43797)

Marco Caliari <caliari>
Group Member
Wed 04 Apr 2018 11:26:53 AM UTC, original submission:  

issymmetric (and ishermitian) can check for skew-symmetry in matlab ("skew" as second argument), but does not allow a tolerance. I think it is possible to make octave compatible and keep the tolerance feature.

Marco Caliari <caliari>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43797:  issymmetric.diff added by caliari (4KiB - application/x-tex)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by dasergatskov (Posted a comment)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by caliari (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-04-12 rik5 Open/ClosedOpen Closed
    2018-04-12 rik5 StatusPatch Submitted Fixed
    2018-04-04 caliari Attached File- Added issymmetric.diff, #43797
        StatusNone Patch Submitted

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code