bugGNU Octave - Bugs: bug #53525, [octave forge] (control) pidstd...

 
 

bug #53525: [octave forge] (control) pidstd cannot be called with default arguments

Submitter:  None
Submitted:  Fri 30 Mar 2018 11:39:31 AM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Christian Gudrian Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 4.2.2
Operating System:  * Mac OS Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 30 Mar 2018 04:08:47 PM UTC, comment #11: 

It's helpful to include a link to the fix

http://hg.code.sf.net/p/octave/control/rev/b3b8186839dd

Mike Miller <mtmiller>
Group Member
Fri 30 Mar 2018 03:11:27 PM UTC, comment #10: 

Wow. That was fast. Thanks a lot!

Christian Gudrian <cgudrian>
Fri 30 Mar 2018 02:43:16 PM UTC, comment #9: 

Done

Alexander Wilms <alexanderw>
Fri 30 Mar 2018 01:47:59 PM UTC, comment #8: 

OK we should follow matlab.
so revert the entire change.

Doug Stewart <dastew>
Fri 30 Mar 2018 01:46:21 PM UTC, comment #7: 

According to math.stackexchange.com [1] infinity is not real, so maybe he made the functions follow the mathematical definition.

But since Matlab defines it as real, I'd avoid inconsistency and just skip the check everywhere.

[1] https://math.stackexchange.com/questions/750777/is-infinity-a-real-number

Alexander Wilms <alexanderw>
Fri 30 Mar 2018 01:40:26 PM UTC, comment #6: 

I am not sure what to do.
Why did he make those changes?
Until we know what he was trying to do i would just fix the one file. Or do you think we should revert the entire change?

Doug Stewart <dastew>
Fri 30 Mar 2018 01:35:12 PM UTC, comment #5: 

Should I revert the entire commit or just for is_real_scalar?

Alexander Wilms <alexanderw>
Fri 30 Mar 2018 01:26:33 PM UTC, comment #4: 

I guess we have to follow matlab.

the fix will have to be in    src/is_real_scalar.cc
Alex can you do this fix?

Doug Stewart <dastew>
Fri 30 Mar 2018 01:05:33 PM UTC, comment #3: 

Matlab 2018a:

>> isscalar(inf)


ans =

  logical

   1

Alexander Wilms <alexanderw>
Fri 30 Mar 2018 01:00:36 PM UTC, comment #2: 

Should inf be considered a scalar?
I don't think it is, but what does matlab do, and what does IEEE say?

I have a change for the "sanity check" that works.

Doug Stewart <dastew>
Fri 30 Mar 2018 12:37:20 PM UTC, comment #1: 
Alexander Wilms <alexanderw>
Fri 30 Mar 2018 11:39:31 AM UTC, original submission:  

The pidstd function performs a sanity check (is_real_scalar) that does not pass with the default arguments (some of which are inf).

I do not know whether is_real_scalar once returned true for inf. At least now it doesn't.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by cgudrian (Posted a comment)
  • -email is unavailable- added by dastew (Posted a comment)
  • -email is unavailable- added by alexanderw (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-30 mtmiller StatusNone Fixed
        Open/ClosedOpen Closed
        Summarycontrol: pidstd cannot be called with default arguments [octave forge] (control) pidstd cannot be called with default arguments

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code