bugGNU Octave - Bugs: bug #53414, make dist produces different...

 
 

bug #53414: make dist produces different contents when built with --without-qt

Submitter:  Mike Miller <mtmiller>
Submitted:  Thu 22 Mar 2018 01:30:04 AM UTC
   
 
Category:  Configuration and Build System Severity:  4 - Important
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 23 Mar 2018 01:55:13 AM UTC, comment #4: 

I added a simple change on stable to resolve this

https://hg.savannah.gnu.org/hgweb/octave/rev/8033e53e6cb4

I haven't thought through whether this will cause any unanticipated problems. But a full build with --without-qt works fine for me, until 'make dist' is run and the correct error is shown.

This doesn't address a build with Qt, but without a DISPLAY at runtime, which will still fall back to using gnuplot to build the graphics for the manual.

Mike Miller <mtmiller>
Group Member
Thu 22 Mar 2018 07:06:48 PM UTC, comment #3: 

Thanks, I agree with everything you said, I will look at adding some more error messages to the dist-hook in doc/interpreter/module.mk.

Mike Miller <mtmiller>
Group Member
Thu 22 Mar 2018 07:04:55 PM UTC, comment #2: 

I'm actually opposed to building the documentation with gnuplot, which in turn, I suppose, requires --with-qt for 'make dist'.

I don't believe that the Octave manual should appear differently depending on the user's computer.  If we require Qt on the distributor's computer then the manual will always be generated with OpenGL renderers and included in the resulting tarball.  Downstream users who merely want to unpack and compile the source code would not need Qt since the documentation had already been generated and shipped.

And I agree, since this is only a problem for distributors, why not force them to have QOffscreenSurface.  Again, I wouldn't want any weirdness caused by the fact that the distributor's computer had hardware-accelerated graphics which didn't play nicely with osmesa.

Rik <rik5>
Group administrator
Thu 22 Mar 2018 01:51:32 AM UTC, comment #1: 

For reference here is the full list of missing files in a dist tarball built without Qt (and without osmesa).

In addition all of the generated figures for the manual are made with gnuplot and some of the figure property default parameters extracted for the manual are wrong because they are gnuplot defaults.

I have no problem with declaring that our 'make dist' requires Qt and OpenGL. We might even require QOffscreenSurface to make sure that the invisible figures built for the manual are handled properly.

(file #43619)

Mike Miller <mtmiller>
Group Member
Thu 22 Mar 2018 01:30:04 AM UTC, original submission:  

I was comparing a octave-4.3.0+.tar.xz source tarball with another one built on a different machine. The contents of the tarballs were different because one was built on a system with Qt dev packages and one was not. I think we need to decide if we're ok with requiring Qt development libraries and tools for building the dist source tarball, and if so, add an error message when make dist runs similar to

https://hg.savannah.gnu.org/hgweb/octave/file/0480c934fbce/doc/interpreter/module.mk#l301

The latest bunch of files missing from the distribution are the doc/interpreter/octave_interpreter.q{ch,hc} files, but there are a lot more:

  • libgui/*/*.ui
  • libgui/graphics/images
  • libgui/languages
  • libgui/src/icons


Basically a bunch of Qt source files are missing from the distribution if the original host didn't have Qt dev packages or built with --without-qt.

Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #43619:  dist-missing-files.txt added by mtmiller (4KiB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-23 mtmiller StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2018-03-22 mtmiller Attached File- Added dist-missing-files.txt, #43619

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code