bugGNU Octave - Bugs: bug #53315, Redundant conditional test in...


bug #53315: Redundant conditional test in HoverToolButton::eventFilter of variable editor

Submitted by:  Dan Sebald <sebald>
Submitted on:  Sat 10 Mar 2018 10:32:49 AM UTC  
Category: GUISeverity: 3 - Normal
Priority: 5 - NormalItem Group: Other
Status: NoneAssigned to: None
Originator Name: Open/Closed: Open
Release: devOperating System: Any

Add a New Comment(Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Mon 12 Mar 2018 09:57:17 PM UTC, comment #1:

There is an enumerated double-click event, QEvent::MouseButtonDblClick.

But why would that cause a right-click context menu to appear? If I try a double right-click in Firefox, for example, the second click just closes the context menu back down without selecting anything.

Rik <rik5>
Project Administrator
Sat 10 Mar 2018 10:32:49 AM UTC, original submission:

I just noticed in the code:

has a redundant test for MouseButtonPress. I can't recall what I was thinking at the time, but I'll look at this again at some point. The hover tool button is the graph button that pops up a context menu. Maybe I was thinking the second one should be "mouse double click" whatever expression is defined for that event.

Dan Sebald <sebald>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by sebald (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    No Changes Have Been Made to This Item

    Back to the top

    Powered by Savane 3.1-cleanup1