bugGNU Octave - Bugs: bug #53274, Variable Editor: Displayed...

 
 

bug #53274: Variable Editor: Displayed variable name is in strange highlighting

Submitter:  Rik <rik5>
Submitted:  Sat 03 Mar 2018 03:23:38 PM UTC
   
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Tue 06 Mar 2018 05:58:52 PM UTC, comment #11: 

Pushed Dan's patch as changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/bf1bace6d01d

Pushed a fix for issue of comment #6 with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/74229798f604

Closing the report.

Torsten Lilge <ttl>
Group Member
Tue 06 Mar 2018 04:10:26 PM UTC, comment #10: 

As it happens, I used to be an electrical engineer doing a lot of schematic design, and I really did like a low-light cubicle with a dark screen and dark theme.

Rik <rik5>
Group administrator
Tue 06 Mar 2018 06:44:37 AM UTC, comment #9: 

I will push Dan's patch and provide a patch for the issue mentioned in comment #6 tonight.

Torsten Lilge <ttl>
Group Member
Tue 06 Mar 2018 04:49:39 AM UTC, comment #8: 

I recall CAD workers liking black backgrounds.  Anyway, no reason to not apply the changeset that I can see.  It's small and a more proper way of doing things.  It's better to use the work Qt put into the framework until it makes sense to deviate.

Dan Sebald <sebald>
Mon 05 Mar 2018 10:55:45 PM UTC, comment #7: 

I just tested Dan's patch from comment #5 and it does the right thing for me.  Is there any reason not to apply it?

Regarding comment #6, I checked my Octave preferences and the Custom Style checkbox for "Dock widget title bar " is unset.

Rik <rik5>
Group administrator
Sun 04 Mar 2018 11:15:28 AM UTC, comment #6: 

@Rik (OT): Regarding the dock widgets of the main window, the black (un)dock and hide buttons are not very suitable for that dark title bar color. Are you using custom styled title bars?

Torsten Lilge <ttl>
Group Member
Sun 04 Mar 2018 09:57:37 AM UTC, comment #5: 

Qt has a means of selecting the operating system's GUI palette that I was unaware of:

http://doc.qt.io/qt-5/qpalette.html#ColorRole-enum

Give the attached patch a try and let me know whether this does what is advertised on your setup.  It should pick the background color that you typically get from most applications and automatically provide a contrasting color for the text.

(file #43456)

Dan Sebald <sebald>
Sun 04 Mar 2018 05:53:08 AM UTC, comment #4: 

Might as well try the easy alternatives first.  Give the attached patch a try and let me know what you think.  QFrame has a wealth of box/panel/etc.

(file #43447)

Dan Sebald <sebald>
Sun 04 Mar 2018 12:36:32 AM UTC, comment #3: 

I don't object to highlighting the active window, my problem is that the color scheme chosen was unreadable.  I'm all for highlighting, but we need to have Qt, or our own code, work out complementary colors.

Rik <rik5>
Group administrator
Sat 03 Mar 2018 10:02:48 PM UTC, comment #2: 

Or make the highlight color formulaic.  In terms of color triad, say HSV, the text and background have different value, so we could pick the highlight at a similar value as the background, but different hue.  Another alternative... yes, it looks like QLabel is derived from QFrame:

http://doc.qt.io/qt-5/qlabel.html
http://doc.qt.io/qt-5/qframe.html

and QFrame should have a border attribute.  So rather than highlight, we could put a border around the active variable which has the same color as the font.

Dan Sebald <sebald>
Sat 03 Mar 2018 09:00:29 PM UTC, comment #1: 

That's a design element.  Open eight variables in the editor


for i=1:8
  eval(['var' num2str(i) ' = eye(5); openvar var' num2str(i)]);
end


undock a few and start clicking between variables to see why that highlight was added.  The highlight represents the active variable, the one for which the toolbar buttons apply to.

You mention the other dock widgets and their labels.  There is a common ancestor now called "label_dock_widget" to allow access to that label.

We could make the highlight only present if there is more than one variable open in the V.E.  But I think the bigger issue in your case is that the color choice of the highlight obscures gray text with the black background.  Preference setting?  Use bold font instead?  Use an asterisk next to the variable name?

Dan Sebald <sebald>
Sat 03 Mar 2018 03:23:38 PM UTC, original submission:  

The Variable Editor was recently changed to use a multiple window display.  However, I am seeing a funny highlight of the title of the window that contains the variable editor when the window is selected.  See the attached var_editor.1.png.

When the window is not selected, the title appears normally.  See var_editor.2.png.

The same thing doesn't happen with the Workspace Window which I show in the second png file.

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by sebald (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-06 ttl StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2018-03-05 rik5 StatusNone In Progress
    2018-03-04 sebald Attached File- Added octave-ve_panel_name_focus_prop_alternative2-djs2018mar04.patch, #43456
    2018-03-04 sebald Attached File- Added octave-ve_panel_name_focus_prop_alternative1-djs2018mar03.patch, #43447
    2018-03-03 rik5 Attached File- Added var_editor.1.png, #43442
        Attached File- Added var_editor.2.png, #43443

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code