bugGNU Octave - Bugs: bug #53259, dev branch fails to build with Qt 4

 
 

bug #53259: dev branch fails to build with Qt 4

Submitter:  Mike Miller <mtmiller>
Submitted:  Fri 02 Mar 2018 03:44:16 AM UTC
   
 
Category:  Configuration and Build System Severity:  4 - Important
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 02 Mar 2018 06:38:37 PM UTC, comment #10: 

I think the only organizational schemes that make sense are either all in one file or each macro in its own separate file. Separate files only make sense if you plan on making them modular so they could be split off into a separate project like gnulib or autoconf-archive.

Mike Miller <mtmiller>
Group Member
Fri 02 Mar 2018 06:30:34 PM UTC, comment #9: 

I don't think it is worth splitting--"One man's meat is another man's poison".  In this case, any organizational grouping picked probably only makes intuitive sense to the person whou picked it.  Also, we really don't need to touch acinclude.m4 very often.  I don't think it's worth the hassle.

Rik <rik5>
Group administrator
Fri 02 Mar 2018 06:13:25 PM UTC, comment #8: 

Thanks, I finally got around to retrying my Qt 4 build and it's fine here as well, no errors or warnings.

Mike Miller <mtmiller>
Group Member
Fri 02 Mar 2018 05:38:00 PM UTC, comment #7: 

Thanks for the cleanup.  I hesitated on the one macro because it was already so long.

acinclude.m4 is definitely getting out of control.  Maybe we should split it up into separate sections for the following classes of macros: C++, LLVM, Qt, external programs, and other miscellaneous things?

John W. Eaton <jwe>
Group administrator
Fri 02 Mar 2018 05:12:59 PM UTC, comment #6: 

And another typo (http://hg.savannah.gnu.org/hgweb/octave/rev/e08c1fea96c5).

On the bright side, I compiled with Qt4 and that does work now.  Closing report.

Rik <rik5>
Group administrator
Fri 02 Mar 2018 04:42:33 PM UTC, comment #5: 

And of course I also pushed a typo at the same time.  I fixed that here (http://hg.savannah.gnu.org/hgweb/octave/rev/cce5d2ea39ff).

Rik <rik5>
Group administrator
Fri 02 Mar 2018 04:36:21 PM UTC, comment #4: 

I pushed a further tweak to keep the macros in acinclude.m4 alphabetized (its the only organizational strategy given the length of the list).  I also changed one of the macro names to preserve Autoconf naming conventions.

See http://hg.savannah.gnu.org/hgweb/octave/rev/53f68d0fb122.

Rik <rik5>
Group administrator
Fri 02 Mar 2018 03:04:35 PM UTC, comment #3: 

I pushed this modified version of your changeset:

http://hg.savannah.gnu.org/hgweb/octave/rev/88665923596c

It works for me with Qt4.  Mike, if you confirm, then please close this report.

John W. Eaton <jwe>
Group administrator
Fri 02 Mar 2018 05:22:44 AM UTC, comment #2: 

Does the attached changeset make compilation under Qt4 work?

(file #43436)

Dan Sebald <sebald>
Fri 02 Mar 2018 03:57:15 AM UTC, comment #1: 

All of the errors come from ed9ba20d6ed3, cc Dan S.

Mike Miller <mtmiller>
Group Member
Fri 02 Mar 2018 03:44:16 AM UTC, original submission:  

With recent changes on the default branch, I am unable to build with Qt 4 again:


../octave-default/libgui/src/variable-editor.cc: In member function 'void variable_dock_widget::toplevel_change(bool)':
../octave-default/libgui/src/variable-editor.cc:132:30: error: 'QGuiApplication' has not been declared
           QScreen *pscreen = QGuiApplication::primaryScreen ();
                              ^
../octave-default/libgui/src/variable-editor.cc:134:27: error: 'class QScreen' has no member named 'availableGeometry'
           rect = pscreen->availableGeometry ();
                           ^
../octave-default/libgui/src/variable-editor.cc: In member function 'void variable_editor::construct_tool_bar()':
../octave-default/libgui/src/variable-editor.cc:1439:52: error: 'FindDirectChildrenOnly' is not a member of 'Qt'
       findChildren<HoverToolButton *> (QString (), Qt::FindDirectChildrenOnly);
                                                    ^
../octave-default/libgui/src/variable-editor.cc:1448:58: error: 'FindDirectChildrenOnly' is not a member of 'Qt'
       findChildren<ReturnFocusToolButton *> (QString (), Qt::FindDirectChildrenOnly);
                                                          ^


Mike Miller <mtmiller>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by sebald (Updated the item)
  • -email is unavailable- added by mtmiller
  • -email is unavailable- added by mtmiller (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-02 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2018-03-02 jwe StatusNone Ready For Test
    2018-03-02 sebald Attached File- Added octave-variable_editor_qt4-djs2018mar01.patch, #43436
    2018-03-02 mtmiller Carbon-Copy- Added sebald

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code