bugGNU Octave - Bugs: bug #53257, MXE created NSIS installer no...

 
 

bug #53257: MXE created NSIS installer no longer shows Octave image during installation

Submitter:  Rik <rik5>
Submitted:  Fri 02 Mar 2018 12:24:58 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Microsoft Windows
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 04 Mar 2018 05:30:31 PM UTC, comment #5: 

@JohnD: Thanks, patch works for me.  Marking as fixed and closing report.

Rik <rik5>
Group administrator
Sun 04 Mar 2018 12:45:24 AM UTC, comment #4: 

Pushed http://hg.octave.org/mxe-octave/rev/56320dd51677

A previous patch to nsis was removing static linking to gcc, which for whatever reason is just effecting the win32 build.


John Donoghue <lostbard>
Group Member
Sat 03 Mar 2018 07:21:16 PM UTC, comment #3: 

Works for me in 64 bit, but can confirm it does not work in 32 bit mode on a win10 machine.


John Donoghue <lostbard>
Group Member
Sat 03 Mar 2018 06:34:19 PM UTC, comment #2: 

I used bisection an the problem cset is 4608.  My guess is that it is not the --disable-win-64 flag, but the change MUI settings.


-!include "MUI.nsh"
+!include "MUI2.nsh"


It could be that my Windows XP virtual machine is just too old to support MUI2.nsh.



Rik <rik5>
Group administrator
Fri 02 Mar 2018 11:13:42 AM UTC, comment #1: 

I will take a look - the --disable-win-64 must be doing something as with 64 works for me.

John Donoghue <lostbard>
Group Member
Fri 02 Mar 2018 12:24:58 AM UTC, original submission:  

I am using --disable-win64 if that matters.  I cross-compiled a recent version of the dev sources (8a92f442c4a2) and when I ran the installer the install image to the left of the text was not shown.

This cset looks like a probable one to investigate:


changeset:   4608:dac40a0ff814
user:        John Donoghue
date:        Wed Feb 28 11:01:19 2018 -0500
summary:     nsis: update for 64bit compile




Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-03-04 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2018-03-04 lostbard StatusConfirmed Ready For Test
    2018-03-03 rik5 StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code