bugGNU Octave - Bugs: bug #53019, [octave forge] (signal) zplane...

 
 

bug #53019: [octave forge] (signal) zplane plotting enhancements

Submitted by:  Brian M. Reeder <brianr>
Submitted on:  Tue 30 Jan 2018 04:57:12 PM UTC  
 
Category: Octave Forge PackageSeverity: 2 - Minor
Priority: 3 - LowItem Group: Inaccurate Result
Status: Need InfoAssigned to: None
Originator Name: Brian M. ReederOpen/Closed: Open
Release: 4.2.1Operating System: Microsoft Windows

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 31 Jan 2018 10:18:32 PM UTC, comment #1:

Thanks for your bug report. If you could please provide your changes as a patch against the original zplane.m function file. Also please try to be consistent with the Octave coding style.

The resulting plots look good to me.

Mike Miller <mtmiller>
Project Administrator
Tue 30 Jan 2018 04:57:12 PM UTC, original submission:

Zplane.m

It doesn't correctly indicate multiple poles / zeros.
This is apparent in the demo, with the 'empty a' subplot only showing a single pole at the origin. It seems this has been corrected before, but the original code has not been removed and it over plots the new bit.

It doesn't use system 'colororder'

I have attached my version that:
does correctly identify multiple poles / zeros,
marks close poles / zeros as multiples,
and uses the system 'colororder'

Brian M. Reeder <brianr>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #43110:  zplane.m added by brianr (5KiB - text/plain)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by mtmiller (Posted a comment)
  • -unavailable- added by brianr (Submitted the item)
  • -unavailable- added by brianr
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 15 Feb 2018 09:13:09 PM UTCmtmillerSeverity3 - Normal=>2 - Minor
      Priority5 - Normal=>3 - Low
      Item GroupIncorrect Result=>Inaccurate Result
      StatusPatch Submitted=>Need Info
    Wed 31 Jan 2018 10:18:32 PM UTCmtmillerStatusNone=>Patch Submitted
      Summaryzplane plotting errors=>[octave forge] (signal) zplane plotting enhancements
    Wed 31 Jan 2018 10:10:51 PM UTCmtmillerDependencies-=>bugs #53018 is dependent
    Tue 30 Jan 2018 04:57:12 PM UTCbrianrAttached File-=>Added zplane.m, #43110
      Carbon-Copy-=>Added -unavailable-

    Back to the top


    Powered by Savane 3.1-cleanup1