bugGNU Octave - Bugs: bug #52850, unused parameter warning during...

 
 

bug #52850: unused parameter warning during build

Submitter:  Rik <rik5>
Submitted:  Wed 10 Jan 2018 12:25:30 AM UTC
   
 
Category:  Configuration and Build System Severity:  2 - Minor
Priority:  3 - Low Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 10 Jan 2018 08:48:39 PM UTC, comment #5: 

Buildbot allows a lot of customization, so it is probably possible.  We are also running our own instance of buildbot, so we can do anything we want with it.  But just how to do it is beyond my understanding at the moment.

John W. Eaton <jwe>
Group administrator
Wed 10 Jan 2018 07:12:32 PM UTC, comment #4: 

I guess the question is how does the buildbot determine whether to color a segment red or green?  Is that a user script that we can modify?

Rik <rik5>
Group administrator
Wed 10 Jan 2018 05:12:38 PM UTC, comment #3: 

I think we are capturing stderr.

What I meant was that even when there are compiler warnings in the compile step log file, the waterfall display for that step is still green.  See for example this log file (contains the unused parameter warnings):

  http://buildbot.octave.org:8010/builders/no-extras-debian/builds/1264/steps/compile/logs/stdio

and this summary of the build (the step is still shown in green):

  http://buildbot.octave.org:8010/builders/no-extras-debian/builds/1264

John W. Eaton <jwe>
Group administrator
Wed 10 Jan 2018 04:30:22 PM UTC, comment #2: 

Is there something to change in the buildbot configuration so that we are properly capturing stderr during the compile stage?

I went back and looked at a compile log from an earlier buildbot session and the warnings are there.  See http://buildbot.octave.org:8010/builders/no-extras-debian/builds/1265/steps/compile/logs/stdio

Or is it that the compile warnings are being delivered to stdout and we actually need a post-compile script to grep for "warning:" in the stdout log?

Changing the regexp used might help with some of the test logs as well which often show warnings, but that is simply the use of the warning statement in the code.  For example, from this log: http://buildbot.octave.org:8010/builders/clang-osx/builds/858/steps/test/logs/warnings%20%287%29


 saved_opts = warning ();
 warning ("off", "all");
 warning (saved_opts);
 warning ("off", "ode15s:mass_state_dependent_provided", "local");
 warning ("off", "ode15s:mass_state_dependent_provided", "local");
 warning ("off", "ode15s:mass_state_dependent_provided", "local");
 warning ("off", "ode15s:mass_state_dependent_provided", "local");


If the regexp were changed to "warning:" then these would not appear.  But any real warning would since those are prefaced with "warning:".


Rik <rik5>
Group administrator
Wed 10 Jan 2018 01:53:06 PM UTC, comment #1: 

Fixed with this changeset:

  http://hg.savannah.gnu.org/hgweb/octave/rev/a276f008ea74

There is a buildbot with a minimal configuration, but warnings don't seem to be flagged in the compile step so I didn't realize that these warnings had popped up.

  http://buildbot.octave.org:8010/builders/no-extras-debian


John W. Eaton <jwe>
Group administrator
Wed 10 Jan 2018 12:25:30 AM UTC, original submission:  

I recently configured with just about everything disabled, including hdf5, zlib, and bzip2.  When compiling, which works just fine, I get a bunch of unused parameter warnings.  These all come from the inclusion of ov-base-int.h in files.  An example is shown.


In file included from libinterp/octave-value/ov-int16.cc:48:0:
libinterp/octave-value/ov-base-int.cc: In instantiation of ‘bool octave_base_int_matrix<T>::save_hdf5_internal(octave_hdf5_id, octave_hdf5_id, const char*, bool) [with T = intNDArray<octave_int<signed char> >; octave_hdf5_id = long int]’:
libinterp/octave-value/ov-intx.h:374:12:   required from here
libinterp/octave-value/ov-base-int.h:98:66: warning: unused parameter ‘save_type’ [-Wunused-parameter]
   bool save_hdf5_internal (octave_hdf5_id loc_id, octave_hdf5_id save_type,




Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-01-10 jwe StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2018-01-10 rik5 Severity3 - Normal 2 - Minor
        Priority5 - Normal 3 - Low

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code