bugGNU Octave - Bugs: bug #52758, [octave forge] (signal-1.3.2)...


bug #52758: [octave forge] (signal-1.3.2) fracshift(x,d) don't shift, if d is an integer

Submitted by:  None
Submitted on:  Thu 28 Dec 2017 10:23:09 PM UTC  
Category: Octave Forge PackageSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Incorrect Result
Status: FixedAssigned to: Juan Pablo Carbajal <juanpi>
Originator Name: KlausOriginator Email: -unavailable-
Open/Closed: ClosedRelease: 4.2.1
Operating System: Any

Add a New Comment(Rich Markup)

You are not logged in

Please log in, so followups can be emailed to you.


Sat 20 Jan 2018 12:33:50 AM UTC, comment #2:

I have fixed this issue in the development source tree and improved the function slightly.
Please double check, but I think this is fixed.

commit 131a2629c1a6

Juan Pablo Carbajal <juanpi>
Project MemberIn charge of this item.
Fri 19 Jan 2018 10:55:59 PM UTC, comment #1:

Is anybody reading bug reports from Anonymous Windows users?
I have now registered and try it again...

fracshift(x,d) does not work if x is a row vector and d is an integer.
If d is an exact integer fracshift uses circshift(x,d) in line 41 of fracshift.m. But circshift expects the dimension to shift as 3rd parameter - if it is omitted it shifts the columns and in case of a row vector it does effectively nothing, see following example:

Suggested bugfix:

Other solution: In line 87-92 there is a "check if input is a row vector" and then the row vector transposed in a column vector. Maybe call circshift(x,d) after this (and before the back transpose).

By the way: bug #47387 (signal-1.2.2) is yet not fixed in signal-1.3.2

Klaus Braun <kmb721>
Thu 28 Dec 2017 10:23:09 PM UTC, original submission:

If x is a row vector (most used) then fracshift(x,d) is redirected to circshift(x,d), but with a row vector the current code doesn't work. A working code for row vectors is: circshift(x,d,2). I don't know if other input vectors or matrices have to be considered.



(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by juanpi (Posted a comment)
  • -unavailable- added by kmb721 (Posted a comment)
  • -unavailable- added by jwe (Updated the item)
  • -unavailable- added by None (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.


    Please enter the title of George Orwell's famous dystopian book (it's a date):



    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 20 Jan 2018 12:33:50 AM UTCjuanpiStatusNone=>Fixed
      Assigned toNone=>juanpi
      Operating SystemMicrosoft Windows=>Any
    Tue 09 Jan 2018 08:40:52 PM UTCjweSummarysignal-1.3.2 -> fracshift(x,d) don't shift, if d is an integer=>[octave forge] (signal-1.3.2) fracshift(x,d) don't shift, if d is an integer

    Back to the top

    Powered by Savane 3.1-cleanup1