bugGNU Octave - Bugs: bug #52720, FLTK toolkit highlights 'R' rotate...

 
 

bug #52720: FLTK toolkit highlights 'R' rotate button initially, but then deactivates with mouse press

Submitter:  Dan Sebald <sebald>
Submitted:  Thu 21 Dec 2017 10:41:31 PM UTC
   
 
Category:  Plotting with OpenGL Severity:  2 - Minor
Priority:  3 - Low Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 28 Dec 2017 01:22:00 AM UTC, comment #4: 

I think you're correct that there is really no need to disable the 'R'otate button.  With the Qt toolkit you can always select the rotate tool, even when the axes object is 2-dimensional.  So by removing this feature we're actually making the toolkits more similar.

I pushed the changeset here http://hg.savannah.gnu.org/hgweb/octave/rev/6b685bb172c6.

Instead of straight diffs, if you can supply complete Mercurial changesets it makes thing easier.  See https://www.gnu.org/software/octave/doc/v4.0.0/Contributing-Guidelines.html for more information.  In particular, "Basics of Generating a Changeset" will show you how to set up Mercurial to export a changeset.

Marking this bug as fixed and closing report.

Rik <rik5>
Group administrator
Wed 27 Dec 2017 09:57:45 PM UTC, comment #3: 

I tried to grab the things. I don't think there's any need to calculate the dimensions in this case ( given that plot() is used for ndim==2 only. ) However, if the need be, we can just comment the 'else' condition and get away with it.

Doing this, the 'R' button no longer goes to enabled mode when one clicks on the canvas area. Though I didn't get as to how to disable the rotate ,once enabled. Same is the case with Pan as well, once enabled, we can't disable it by clicking it once again.

P.S:
These were just my thoughts. Any productive criticism is welcomed on the solution I suggested.

(file #42742)

Sahil <batterylow>
Fri 22 Dec 2017 03:09:10 AM UTC, comment #2: 

Yes, it's minor.  I suppose Qt gets priority, but right now FLTK looks to be the nicer of the OpenGL toolkits; my impression anyway.

As an aside and regarding what you mentioned on discussion list, I do notice, though, that zoom(gcf,'off') and zoom(gcf,'on') toggle the Z+ and Z- buttons on the Qt toolkit.  So, zooming seems tied to a figure, hence the legend should not have any kind of zoom property.  When it comes to zooming then, the legend should act as if it is invisible and pass the action on to its parent, if things are set up that way.

Dan Sebald <sebald>
Fri 22 Dec 2017 12:45:00 AM UTC, comment #1: 

I noticed this a while back as well.  It's probably some default button being assigned.  I'll make the severity minor since at some point we probably discontinue FLTK and go with Qt anyways.

Rik <rik5>
Group administrator
Thu 21 Dec 2017 10:41:31 PM UTC, original submission:  

Try the following:


>> close all
>> graphics_toolkit fltk
>> plot(1:10)


This is a 2-D plot.  Without clicking anywhere within the plot, notice that the 'R' button at the bottom of the window is solid, i.e., it can be selected.  If one were to click somewhere within the plot, the 'R' button turns grey and is deactivated.  (If you've just done this, rerun the above script to create a new window.)  However, if one were to click 'R' as the first action when the button is still active, the plot will become rotate-able.  I don't know if that is desired for 2-D plots, but regardless this is quirky behavior that should be changed--either deactivate the button right away or do not deactivate the button at all.

Dan Sebald <sebald>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #42742:  52720.diff added by batterylow (806B - text/x-patch - patchwork)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by batterylow (Updated the item)
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by sebald (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-12-28 rik5 StatusConfirmed Fixed
        Open/ClosedOpen Closed
    2017-12-27 batterylow Attached File- Added 52720.diff, #42742
    2017-12-27 rik5 Priority5 - Normal 3 - Low
    2017-12-22 rik5 Severity3 - Normal 2 - Minor
        StatusNone Confirmed

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code