bugGNU Octave - Bugs: bug #52397, [mxe-octave] ...

 
 

bug #52397: [mxe-octave] of-image-1-fixes.patch is obsolete with image 2.6.2

Submitter:  Avinoam Kalma <avinoam>
Submitted:  Mon 13 Nov 2017 05:18:11 AM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Avinoam Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 15 Nov 2017 04:35:09 AM UTC, comment #2: 

John D has fixed this in http://hg.octave.org/mxe-octave/rev/4e0d5c846b7b.

Closing as fixed

Avinoam Kalma <avinoam>
Group Member
Mon 13 Nov 2017 05:37:06 PM UTC, comment #1: 

The file src/of-image-1-fixes.patch fixes two different things.  One of them is enabling the build in Octave 4.3.  That issue is addressed with the image package release 2.6.2 and should be removed once mxe-octave is updated to the latest image package.

However, it also patches out bug #50153 in bwperim.  This patch has been applied in the default branch of the image package, to be part of the next minor (not patch) release. I don't quite understand why that one change was singled out to be included in mxe-octave. If mxe-octave wants to include unreleased changes, I think it's better that it includes patches from the stable branch only. Unless there's a reason why that bug fix on bwperim needs to be included, I think it should be removed too.

A separate note, may be a good idea to separate patches with different purposes in different files.

Carnë Draug <carandraug>
Group Member
Mon 13 Nov 2017 05:18:11 AM UTC, original submission:  


After the release of image-2.6.2, of-image-1-fixes.patch should be removed. It causes build failure when building MXE-Octave with 2.6.2

Avinoam Kalma <avinoam>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by avinoam (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-11-15 avinoam StatusNone Fixed
        Open/ClosedOpen Closed
    2017-11-13 carandraug Summary[mxe-octave] of-image-1-fixes.patch is obsolete [mxe-octave] of-image-1-fixes.patch is obsolete with image 2.6.2

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code