bugGNU Octave - Bugs: bug #51928, [octave forge] (statistics)...

 
 

bug #51928: [octave forge] (statistics) Failure in unit test of grp2idx function

Submitter:  Rafael Laboissière <rlaboiss>
Submitted:  Sun 03 Sep 2017 08:33:12 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  lostbard
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 20 May 2018 10:39:46 PM UTC, comment #2: 

closing as fixed with latest release of statistics

John Donoghue <lostbard>
Group Member
Tue 08 May 2018 09:00:09 PM UTC, comment #1: 
John Donoghue <lostbard>
Group Member
Sun 03 Sep 2017 08:33:12 PM UTC, original submission:  

A unit test of the function grp2idx of the statistics package (version 1.3.0) is failing with the following error message:
 

octave:1> pkg load statistics
octave:2> test ("grp2idx")
***** assert (nthargout (1:3, @grp2idx, ["sci"; "oct"; "sci"; "oct"; "oct"]),
        {[1; 2; 1; 2; 2] {"sci"; "oct"} ["sci"; "oct"]});
!!!!! test failed
ASSERT errors for:  assert (cond {i},expected {i},tol)

  Location  |  Observed  |  Expected  |  Reason
    (1)           2            1         Abs err 1 exceeds tol 0
    (2)           1            2         Abs err 1 exceeds tol 0
    (3)           2            1         Abs err 1 exceeds tol 0
    (4)           1            2         Abs err 1 exceeds tol 0
    (5)           1            2         Abs err 1 exceeds tol 0

ASSERT errors for:  assert (cond {i},expected {i},tol)

  Location  |  Observed  |  Expected  |  Reason
     []          oct          sci        Strings don't match

ASSERT errors for:  assert (cond {i},expected {i},tol)

  Location  |  Observed  |  Expected  |  Reason
     []          sci          oct        Strings don't match

ASSERT errors for:  assert (cond {i},expected {i},tol)

  Location  |  Observed  |  Expected  |  Reason
     []       osccti       soccit        Strings don't match


However, it is stated in the comment of the test block:


## FIXME this fails because unique() in core does not yet have set_order
##        option implemented.  See code for code to uncomment once it is
##        implemented in core.


In this case, the failing tests should be run with 'xtest', instead of 'test'.  The attached patch fixes this.

Rafael Laboissière <rlaboiss>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #41724:  xtests-in-grp2idx.patch added by rlaboiss (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by rlaboiss (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-05-20 lostbard StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2018-05-08 lostbard StatusNone Ready For Test
        Assigned toNone lostbard
    2017-09-03 rlaboiss Attached File- Added xtests-in-grp2idx.patch, #41724

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code