bugGNU Octave - Bugs: bug #51660, __run_test_suite__ can unwind its...

 
 

bug #51660: __run_test_suite__ can unwind its own return values

Submitter:  Colin Macdonald <cbm>
Submitted:  Fri 04 Aug 2017 06:59:42 PM UTC
   
 
Category:  Test Suite Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Unexpected Error or Warning
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 05 Aug 2017 03:44:26 AM UTC, comment #2: 

This works for me now.  Marking as fixed and closing report.

Rik <rik5>
Group administrator
Fri 04 Aug 2017 11:13:16 PM UTC, comment #1: 

I pushed the following changeset:

http://hg.savannah.gnu.org/hgweb/octave/rev/595d6716e3e2

It seems to fix the immediate problem, but I'm not sure whether there are others related to exception handling/stack unwinding.

John W. Eaton <jwe>
Group administrator
Fri 04 Aug 2017 06:59:42 PM UTC, original submission:  

_run_test_suite_.m does a lot of work inside both a unwind_protect and a try block.  It later uses some of those variables which may have been unwound.

For example, "nfail".

Here's a kind of trivial example, but there may be more significant ones (e.g., after some tests have run).

1.  Suppose I go to some dir where I do not have write permissions.

2.  Try:


>> [passed,failed] = __run_test_suite__ ({'somedir'}, {})

__run_test_suite__: could not open /usr/share/octave/packages/symbolic-2.5.0/fntests.log for writing
error: 'nfail' undefined near line 143 column 12
error: called from
    __run_test_suite__ at line 143 column 10


Colin Macdonald <cbm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by cbm
  • -email is unavailable- added by cbm (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-05 rik5 StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2017-08-04 jwe StatusNone Ready For Test
    2017-08-04 cbm Carbon-Copy- Added mtmiller

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code