bugGNU Octave - Bugs: bug #49481, example embedded.cc includes...

 
 

bug #49481: example embedded.cc includes deprecated header toplev.h

Submitted by:  Carlo de Falco <cdf>
Submitted on:  Sun 30 Oct 2016 03:41:47 PM UTC  
 
Category:  Documentation Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 03 Nov 2016 08:42:14 PM UTC, comment #2: 

I applied this "documentation" fix to the stable branch (http://hg.savannah.gnu.org/hgweb/octave/rev/ea09770fb556).  Thanks, closing report.

Rik <rik5>
Project Administrator
Sun 30 Oct 2016 07:04:52 PM UTC, comment #1: 

This does count as a documentation fix in my book.

However, what are the actual include files you need?  I found that I could compile the file with 2 out of 4 header files commented out.

//#include <octave/oct.h>
#include <octave/octave.h>
#include <octave/parse.h>
//#include <octave/toplev.h>

Should embedded.cc be changed to include only those two files?

Rik <rik5>
Project Administrator
Sun 30 Oct 2016 03:41:47 PM UTC, original submission:  

 $ mkoctfile --link-stand-alone embedded.cc
In file included from embedded.cc:5:0:
/opt/octave/4.3/include/octave-4.3.0+/octave/../octave/toplev.h:28:2: warning: #warning "toplev.h has been deprecated; use interpreter.h instead" [-Wcpp]
#warning "toplev.h has been deprecated; use interpreter.h instead"
  ^

I tried with the default branch, but I guess it is the same with stable ...

Does this actually qualify as a documentation fix that can be applied on the stable branch?

Carlo de Falco <cdf>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #38841:  open_mmhRWVfm.txt added by cdf (664B - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by cdf (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-11-03 rik5 StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2016-10-30 cdf StatusNone => Patch Submitted
    2016-10-30 cdf Attached File- => Added open_mmhRWVfm.txt, #38841

    Back to the top


    Powered by Savane 3.5