bugGNU Octave - Bugs: bug #49034, test __osmesa_print__ FAILS with...

 
 

bug #49034: test __osmesa_print__ FAILS with newer versions of gl2ps

Submitted by:  Dmitri A. Sergatskov <dasergatskov>
Submitted on:  Fri 09 Sep 2016 04:16:50 AM UTC  
 
Category:  Test Suite Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  None
Originator Name:  Dmitri A. Sergatskov Open/Closed:  Closed
Release:  dev Operating System:  GNU/Linux

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 22 May 2017 09:36:42 PM UTC, comment #5: 

Works fine on my machine(s).

Thanks!

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Mon 22 May 2017 08:43:45 PM UTC, comment #4: 

I checked in a change that increases the tolerance here (http://hg.savannah.gnu.org/hgweb/octave/rev/ed2239ed5fd3).  Marking as "Ready for Test".

Rik <rik5>
Project Administrator
Mon 22 May 2017 03:31:33 AM UTC, comment #3: 

With gl2ps-1.4.0 is out the size of the files increased quite dramatically. For AMD / gallium graphics I get

 __osmesa_print__ (hf, fn, "svg");
...
Location  |  Observed  |  Expected  |  Reason
     ()        3331917      2579392      Rel err 0.29175 exceeds tol 0.1

...
__osmesa_print__ (hf, fn, "svgis2d");
...
Location  |  Observed  |  Expected  |  Reason
     ()          7699         6276       Rel err 0.22674 exceeds tol 0.1

Fedora 26 will have gl2ps-1.4.0 and is scheduled to be released in about a  month. So I expect that there will be linux distributions with gl2ps versions from 1.3.8
(Redhat 7, Ubuntu trusty, other LTS distros?) to 1.4.0 for a at least a year ahead.

So we should either increase tol to like 50% (or at least 33%),
or make it xfail.

Dmitri.
--

Dmitri A. Sergatskov <dasergatskov>
Thu 15 Sep 2016 06:35:37 PM UTC, comment #2: 

On my development system using a self-compiled gl2ps-1.3.9 the size is 2514240.  Clearly, the size is only a rough check and we should probably just acknowledge that this is not very precise.  With the 5 samples in this report I see results of

2420056
2442761
2514240
2692270
2738728

If I take the average of the min and max values I get a new expected value of 2579392.  Now the two endpoints are 6.2% away from this value so we can keep the 10% relative tolerance.

I made that change here (http://hg.savannah.gnu.org/hgweb/octave/rev/dbe0ec8d53b5).  Marking the bug as Ready for Test.

Rik <rik5>
Project Administrator
Sat 10 Sep 2016 03:46:37 PM UTC, comment #1: 

This test clearly depends on the version of gl2ps: on linux mint 1.3.8 is the default and the file is 2442761 bytes large while if I LD_PRELOAD the current development version the size is 2738728.
We should either increase the tolerance or make the footprint version dependent.

Pantxo Diribarne <pantxo>
Project Member
Fri 09 Sep 2016 04:16:50 AM UTC, original submission:  

 test _osmesa_print_.cc-tst is failing on all Fedora 24 or 25
computers i tried. This is on AMD

test _osmesa_print_.cc-tst

          • testif HAVE_OPENGL, HAVE_OSMESA, HAVE_GL2PS_H

if (isunix ())
   hf = figure ("visible", "off");
   fn = tempname ();
   unwind_protect
     sombrero ();
     _osmesa_print_ (hf, fn, "svg");
     assert (stat (fn).size, 2692270, -0.1);
     img = _osmesa_print_ (hf);
     assert (size (img), [get(hf, "position")([4, 3]), 3]);
     ## Use pixel sum per RGB channel as fingerprint
     img_fp = squeeze (sum (sum (img), 2));
     assert (img_fp, [52942515; 54167797; 56158178], -0.05);
   unwind_protect_cleanup
     close (hf);
     unlink (fn);
   end_unwind_protect
 endif
!!!!! test failed
ASSERT errors for:  assert (stat (fn).size,2692270,-0.1)

  Location  |  Observed  |  Expected  |  Reason
     ()        2420056      2692270      Rel err 0.10111 exceeds tol 0.1

(I attached the resulting svg file).

rpm -qi gl2ps
Name        : gl2ps
Version     : 1.3.9
Release     : 2.fc24
Architecture: x86_64
Install Date: Wed 11 May 2016 08:21:55 PM CDT
Group       : System Environment/Libraries
Size        : 117122
License     : LGPLv2+ or GL2PS
Signature   : RSA/SHA256, Sat 06 Feb 2016 01:32:26 PM CST, Key ID 73bde98381b46521
Source RPM  : gl2ps-1.3.9-2.fc24.src.rpm
Build Date  : Wed 03 Feb 2016 06:34:13 PM CST
Build Host  : buildvm-24.phx2.fedoraproject.org

Dmitri.

Dmitri A. Sergatskov <dasergatskov>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by pantxo (Posted a comment)
  • -email is unavailable- added by opoplawski (me too)
  • -email is unavailable- added by dasergatskov (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-05-22 rik5 StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2017-05-22 rik5 StatusFixed => Ready For Test
    2017-05-22 rik5 Open/ClosedClosed => Open
        Summarytest _osmesa_print_ FAILS on Fedora 24/25 => test __osmesa_print__ FAILS with newer versions of gl2ps
    2016-09-19 rik5 StatusReady For Test => Fixed
        Open/ClosedOpen => Closed
    2016-09-15 rik5 StatusConfirmed => Ready For Test
    2016-09-10 pantxo StatusNone => Confirmed
    2016-09-09 opoplawski Carbon-Copy- => Added opoplawski

    Back to the top


    Powered by Savane 3.5