bugGNU Octave - Bugs: bug #48106, Image package: error in make clean

 
 

bug #48106: Image package: error in make clean

Submitter:  Avinoam Kalma <avinoam>
Submitted:  Fri 03 Jun 2016 06:15:40 AM UTC
   
 
Category:  Octave Package Severity:  2 - Minor
Priority:  3 - Low Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Avinoam Open/Closed:  * Closed
Release:  * dev Operating System:  * Any
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 04 Jun 2016 07:45:10 PM UTC, comment #2: 

Thank you Mike. I have pushed your fix for the clean logic.

http://hg.code.sf.net/p/octave/image/rev/28deaa12353d

However, for the missing im2double I used greps -s flag which is more specific for missing files. I understand that it's not as portable, but I'm already using -Po options.

http://hg.code.sf.net/p/octave/image/rev/f9ef5ea753ef

Carnë Draug <carandraug>
Group Member
Fri 03 Jun 2016 06:56:45 PM UTC, comment #1: 

There are two separate unrelated issues here, and neither of them are really that problematic.

The error message about src/im2double.m can be safely ignored, but it could also be silenced with a small patch.

The error when you try to run `make clean` is because you haven't run `make all` yet, so there is no file `src/Makefile`. The fix for this is also simple, just invert the test logic.

I've pushed changesets fixing these two issues to bitbucket, one on the stable branch and on on default. Carnë please pull or adapt as you like into your repository.

https://bitbucket.org/mtmiller/octave-image/commits/28deaa12353d
https://bitbucket.org/mtmiller/octave-image/commits/c2c48bf422f1

Mike Miller <mtmiller>
Group Member
Fri 03 Jun 2016 06:15:40 AM UTC, original submission:  



$  hg clone  http://hg.code.sf.net/p/octave/image
destination directory: image
requesting all changes
adding changesets
adding manifests
adding file changes
added 1125 changesets with 2541 changes to 403 files
updating to bookmark @
201 files updated, 0 files merged, 0 files removed, 0 files unresolved
$ cd image
$ make dist
grep: src/im2double.m: No such file or directory
Creating package version 2.5.1 release ...
rm -rf "target/image-2.5.1"
hg archive --exclude ".hg*" --exclude "Makefile" --exclude "HACKING" \
          --exclude "devel" --type files "target/image-2.5.1"
cd "target/image-2.5.1" && ./bootstrap && rm -rf "src/autom4te.cache"
chmod -R a+rX,u+w,go-w "target/image-2.5.1"
tar -c -f - --posix -C "target/" "image-2.5.1" | gzip -9n > "target/image-2.5.1.tar.gz"
$ make clean
grep: src/im2double.m: No such file or directory
rm -rf target
test -e src/Makefile && make -C src clean
make: *** [clean] Error 1


note the lines
grep: src/im2double.m: No such file or directory

and the error at the end

Avinoam Kalma <avinoam>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by mtmiller
  • -email is unavailable- added by avinoam (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-06-04 carandraug StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2016-06-03 mtmiller Severity3 - Normal 2 - Minor
        Priority5 - Normal 3 - Low
        Item GroupRegression Incorrect Result
        StatusNone Patch Submitted
        Operating SystemGNU/Linux Any
        Carbon-Copy- Added carandraug

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code