bugGNU Octave - Bugs: bug #47961, system.tst fails because...

 
 

bug #47961: system.tst fails because octave::sys::umask is endlessly recursive

Submitter:  Lachlan Andrew <lachlan>
Submitted:  Thu 19 May 2016 01:49:21 PM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Regression
Status:  Fixed Assigned to:  None
Originator Name:  Lachlan Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 19 May 2016 02:31:38 PM UTC, comment #4: 

Thanks both, all looks good here.

Mike Miller <mtmiller>
Group Member
Thu 19 May 2016 02:18:41 PM UTC, comment #3: 

I applied your patch.

Thanks.

John W. Eaton <jwe>
Group administrator
Thu 19 May 2016 02:12:49 PM UTC, comment #2: 

So we're talking about umask, not uname? :)

Confused before I saw the patch, because I only see ::uname being called.

Testing now.

Mike Miller <mtmiller>
Group Member
Thu 19 May 2016 01:56:16 PM UTC, comment #1: 

I notice that most functions in file-ops.cc call the gnulib functions, rather than the ones in the global namespace.  However, (on my system at least) there is no umask in gnulib, and so the attached patch just calls ::uname.

(file #37208)

Lachlan Andrew <lachlan>
Thu 19 May 2016 01:49:21 PM UTC, original submission:  

The new function octave::sys::uname calls "uname ()", instead of "::uname".

I'll attach the patch once I have a bug number.

Lachlan Andrew <lachlan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #37208:  bug_47961_umask.cset added by lachlan (757B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by mtmiller (Posted a comment)
  • -email is unavailable- added by lachlan (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-05-19 jwe StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
        Summarysystem.tst fails because octave::sys::uname is endlessly recursive system.tst fails because octave::sys::umask is endlessly recursive
    2016-05-19 mtmiller StatusNone Patch Submitted
    2016-05-19 lachlan Summaryoctave::sys::uname is endlessly recursive system.tst fails because octave::sys::uname is endlessly recursive
    2016-05-19 lachlan Attached File- Added bug_47961_umask.cset, #37208

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code