bugGNU Octave - Bugs: bug #46054, make rules for *.df ignore user...

 
 

bug #46054: make rules for *.df ignore user CXXFLAGS

Submitter:  Carnë Draug <carandraug>
Submitted:  Sat 26 Sep 2015 03:51:57 PM UTC
   
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 28 Sep 2015 08:27:37 AM UTC, comment #2: 

ok. I pushed the patch.

Carnë Draug <carandraug>
Group Member
Mon 28 Sep 2015 12:24:58 AM UTC, comment #1: 

The patch looks good to me.  I think it was just an oversight when jwe transitioned away from recursive make.  The code duplication isn't a problem.

Rik <rik5>
Group administrator
Sat 26 Sep 2015 03:51:57 PM UTC, original submission:  

The rules for df do not make use of the user defined CXXFLAGS. This is working fine in the stable branch. The reason is that these got dropped when removing the recursive make:

http://hg.savannah.gnu.org/hgweb/octave/rev/0ce7d8303152#l5.534

http://hg.savannah.gnu.org/hgweb/octave/rev/0ce7d8303152#l9.362

http://hg.savannah.gnu.org/hgweb/octave/rev/0ce7d8303152#l10.265


The attached changeset fixes the issue.  However, I also noticed that these 3 rules are quite similar among them so maybe there's a better way to do this that would avoid code duplication?

One of this issue was causing a build failure, and I found the other two by running the following on the build tree (but maybe this is still missing some other cases?)


$ grep -nrP -A 2 '_CXXLAGS\) (?!\$\(CXXFLAGS\))
$ grep -nrP -A 2 '_CLAGS\) (?!\$\(CFLAGS\))
$ grep -nrP -A 2 '_FFLAGS\) (?!\$\(FFLAGS\))


Carnë Draug <carandraug>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #34990:  df-cxxflags.cset added by carandraug (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by carandraug (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-09-28 carandraug StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2015-09-26 carandraug Attached File- Added df-cxxflags.cset, #34990

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code