bugGNU Octave - Bugs: bug #44451, generate_html tip adds extra...

 
 

bug #44451: generate_html tip adds extra "<pre> </pre>" for @group

Submitter:  Colin Macdonald <cbm>
Submitted:  Fri 06 Mar 2015 02:34:29 PM UTC
   
 
Category:  Octave Package Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Documentation
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * dev Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 09 Mar 2015 06:49:21 PM UTC, comment #5: 

This bug report can be closed, I think.

Julien Bect <jbect>
Mon 09 Mar 2015 08:03:51 AM UTC, comment #4: 

Here it is:

http://sourceforge.net/p/octave/generate_html/ci/bf584a44e09924849c353ad351166fb7d1252b7a/

I hope it doesn't break anything. It doesn't seem to. Can you test it ?

Julien Bect <jbect>
Sun 08 Mar 2015 12:34:13 AM UTC, comment #3: 

Yes that works great!  thanks.

I wonder about also chopping a single space char from all lines (if present of course).  Surely most code has "## y = 5" and it could go to "<pre>y = 5</pre>" (instead of current "<pre> y = 5</pre>").  Just a thought.  Do you want another bug filed?


Colin Macdonald <cbm>
Sat 07 Mar 2015 12:34:54 PM UTC, comment #2: 

Hi Colin,

I have pushed a changeset that seems to solve the problem:

http://sourceforge.net/p/octave/generate_html/ci/c0ad0267e85bd1ec876469de30d7587c8aed8547/

Can you tell me if it works for you ?

@++
Julien

Julien Bect <jbect>
Sat 07 Mar 2015 09:02:02 AM UTC, comment #1: 

The extra <pre> </pre> block is created by makeinfo itself.

You can get rid of it by removing the extra space in front of @group (i.e., ## @group -> ##@group).

I will fix this by removing leading spaces in substrings of the form ##\s*@group.

Julien Bect <jbect>
Fri 06 Mar 2015 02:34:29 PM UTC, original submission:  

Using hg tip of generate_html.  If my texinfo looks like:


%% Examples:
%% @example
%% syms x a c


then html_help_text gives:


<p>Examples:
 </p><div class="example">
<pre class="example"> syms x a c


Which is good.  But I [read](https://www.gnu.org/software/octave/doc/interpreter/Documentation-Tips.html) that I should use @group for better pagination:


%% Examples:
%% @example
%% @group
%% syms x a c


But now html_help_text gives:


<p>Examples:
 </p><div class="example">
<pre class="example"> </pre><pre class="example"> syms x a c


Note the "<pre> </pre>" which introduces an extra white-space only line.

Colin Macdonald <cbm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by mtmiller (Updated the item)
  • -email is unavailable- added by jbect (Posted a comment)
  • -email is unavailable- added by cbm (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-13 mtmiller StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-aa77.
    Corresponding source code