bugGNU Octave - Bugs: bug #43814, Octave:num-to-str warning is never...

 
 

bug #43814: Octave:num-to-str warning is never issued

Submitter:  Rik <rik5>
Submitted:  Sun 14 Dec 2014 12:43:43 AM UTC
   
 
Category:  Interpreter Severity:  2 - Minor
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * other Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 16 Dec 2014 06:17:58 AM UTC, comment #4: 

I committed the changeset to stable, since this is a regression from before 3.2.4, and pulled the changes through gui-release and on to the default branch.

Closing report.

Rik <rik5>
Group administrator
Mon 15 Dec 2014 10:30:40 PM UTC, comment #3: 

Rik, your change looks reasonable to me.

John W. Eaton <jwe>
Group administrator
Mon 15 Dec 2014 05:17:12 AM UTC, comment #2: 

I've attached a patch that restores the Octave:num-to-str warning.

I've asked on the Octave Maintainer's list about octave_char_matrix which was supposed to issue this warning, but may be deprecated.

(file #32668)

Rik <rik5>
Group administrator
Sun 14 Dec 2014 08:53:53 AM UTC, comment #1: 

I get a warning if I enable "Octave:mixed-string-concat"


warning ("on", "Octave:mixed-string-concat")
["a", 111]
warning: concatenation of different character string types may have unintended consequences


This comes from pt-mat.cc:678:maybe_warn_string_concat
because 111 is here already treated as single quoted string. I think this is strongly related to bug #43815 and #42651

Andreas Weber <andy1978>
Group Member
Sun 14 Dec 2014 12:43:43 AM UTC, original submission:  

According to warning_ids(), the following code should produce a warning.


warning ("on", "Octave:num-to-str")
[ "f", 111, 111 ]


However, no warning is issued and this seems to be a long-standing problem.  I checked in versions 3.2.4, 3.4.3, 3.6.4, 3.8.2, and the development branch and nothing happens.

Rik <rik5>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32668:  num2str.cset added by rik5 (3KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by jwe (Posted a comment)
  • -email is unavailable- added by rik5
  • -email is unavailable- added by andy1978 (Posted a comment)
  • -email is unavailable- added by rik5 (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-12-16 rik5 StatusPatch Submitted Fixed
        Open/ClosedOpen Closed
    2014-12-15 rik5 Attached File- Added num2str.cset, #32668
        StatusNone Patch Submitted
    2014-12-15 rik5 Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code