bugGNU Octave - Bugs: bug #43670, Vertical concetanation of...

 
 

bug #43670: Vertical concetanation of arguments bug in __patch__.m

Submitter:  None
Submitted:  Sat 22 Nov 2014 06:48:54 AM UTC
   
 
Category:  Plotting Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Assigned to:  None
Originator Name:  Antonio Originator Email:  -email is unavailable-
Open/Closed:  * Closed Release:  * 3.8.1
Operating System:  * Any Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 23 Nov 2014 05:08:11 AM UTC, comment #3: 

Thanks.  I made the change on the stable branch in this changeset (http://hg.savannah.gnu.org/hgweb/octave/rev/2da8f0c6e8a3).  It will be a part of the 3.8.3 bug fix release, if there is one.  More likely the next release will be 4.0 with the GUI and it will show up there.  For the time being, you can just patch your local copy of _patch_.m.

Again, thanks for noticing this.  Closing report.

Rik <rik5>
Group administrator
Sun 23 Nov 2014 01:47:26 AM UTC, comment #2: 

Sorry for not originally posting a minimal working example.  I figured it was straightforward enough to not need explanation.

Any call using a struct tickles the bug.

E.g.

X.vertices = [1 0 0; 0 1 0; 0 0 1];
X.faces = [1 2 3];
patch(X, 'FaceColor', 'blue');


I'm surprised it hasn't been discovered earlier.  It's still in the dev version (4.1.0+)

Anonymous
Sat 22 Nov 2014 06:56:32 PM UTC, comment #1: 

Could you provide sample code that reproduces the error so that we can verify that there is a problem, and that the proposed solution fixes it?

I suspect that this is the right thing to do because further down in the input checking code we have


args = [args, varargin(iarg:end)]


where the concatenation is clearly into a row vector.

Rik <rik5>
Group administrator
Sat 22 Nov 2014 06:48:54 AM UTC, original submission:  

In _patch_.m, arguments, "args", should be horizontally concatenated instead of vertically.  Failing to do so leads a dimension mis-match error.

_patch_.m, line 52

args = [args varargin(2:end)];


instead of :

args = [args; varargin(2:end)];


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-11-23 rik5 StatusNeed Info Fixed
        Open/ClosedOpen Closed
    2014-11-22 rik5 StatusNone Need Info

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code