bugGNU Octave - Bugs: bug #43295, [MXE}...

 
 

bug #43295: [MXE} stable-octave-1-gnulib-isatty.patch patch fails against stable branch

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Wed 24 Sep 2014 08:18:36 PM UTC  
 
Category:  Configuration and Build System Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Build Failure
Status:  Invalid Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  Closed
Release:  other Operating System:  Other

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 25 Sep 2014 05:57:04 AM UTC, comment #4: 

Yeah I figured the choice between stable-octave and octave would play a role here :-)  Simply moving the patch out of src/ made the build succeed.

BTW I saw isatty.c has similar, but not quite identical code as the patch. (Didn't look at select.c)

Philip Nienhuis <philipnienhuis>
Project Member
Thu 25 Sep 2014 12:26:48 AM UTC, comment #3: 

For the latest stable, the patch isnt required as it has already been applied to gnulib

John Donoghue <lostbard>
Project Member
Thu 25 Sep 2014 12:13:58 AM UTC, comment #2: 

The patches are only guarenteed to work for the verson they were made for - in this case the release of 3.8.2.

Fixing it to work with the current unreleased stable will probally make it not work for the stable release.

Perhaps we should use the non stable option enabled in configure with --disable-stable, and change it to periodically be able to build pre release versions/fix patches ?

John Donoghue <lostbard>
Project Member
Wed 24 Sep 2014 08:19:18 PM UTC, comment #1: 

adapted title: release -> branch

Philip Nienhuis <philipnienhuis>
Project Member
Wed 24 Sep 2014 08:18:36 PM UTC, original submission:  

(On Linux, cross-building)

cloned mxe-octave repo
autoconf
./configure --enable-64

cloned stable ( hg http://www.octave.org/hg/octave -b stable <local-repo> )
./bootstrap
<cd build dir>
../<local-repo>/configure ; make ; make check ; make all dist
.........transplant tar.gz to mxe, update stable-octave.mk package name (.tat.gz) and SHA1

make tar-dist

and the build breaks at building stable-octave with (stable-octave.log):

make[1]: Entering directory '/home/philip/devel/octdev/mxe/mxe140920_64'
:
:
(cd '/home/philip/devel/octdev/mxe/mxe140920_64/tmp-stable-octave/octave-3.8.2' && patch -p1 -u) < /home/philip/devel/octdev/mxe/mxe140920_64/src/stable-octave-1-gnulib-isatty.patch
patching file libgnu/isatty.c
Hunk #1 FAILED at 34.
1 out of 1 hunk FAILED -- saving rejects to file libgnu/isatty.c.rej
patching file libgnu/select.c
Hunk #1 FAILED at 84.
1 out of 1 hunk FAILED -- saving rejects to file libgnu/select.c.rej
/home/philip/devel/octdev/mxe/mxe140920_64/Makefile:674: recipe for target 'build-only-stable-octave' failed
make[1]: *** [build-only-stable-octave] Error 1
make[1]: Leaving directory '/home/philip/devel/octdev/mxe/mxe140920_64'

The relevant gnulib modules (isatty.c and select.c) indeed do not match the pattern that the patch expects

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-09-26 philipnienhuis StatusNone => Invalid
        Open/ClosedOpen => Closed
    2014-09-24 philipnienhuis Summary[MXE} stable-octave-1-gnulib-isatty.patch patch fails against stable release => [MXE} stable-octave-1-gnulib-isatty.patch patch fails against stable branch

    Back to the top


    Powered by Savane 3.5