bugGNU Octave - Bugs: bug #43196, [GUI] Underscores in variable...

 
 

bug #43196: [GUI] Underscores in variable names aren't shown in workspace

Submitted by:  Philip Nienhuis <philipnienhuis>
Submitted on:  Thu 11 Sep 2014 01:51:32 PM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Other
Status:  Fixed Assigned to:  None
Originator Name:  Philip Nienhuis Open/Closed:  Closed
Release:  dev Operating System:  Microsoft Windows

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 26 Sep 2014 05:35:35 AM UTC, comment #10: 

Pushed the patch with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/362071d9bf5b
and closing the report

Torsten Lilge <ttl>
Project Member
Sat 13 Sep 2014 08:40:21 AM UTC, comment #9: 

Tried your patch with and without alternating row colors (the latter like Matlab).
Yet I like alternating row colors the best (cf. your patch). I suppose that will also look better with larger fonts as well (like John D. has).

Philip Nienhuis <philipnienhuis>
Project Member
Fri 12 Sep 2014 06:12:30 PM UTC, comment #8: 

The attached patch adds alternating row colors instead of grid lines for testing.

(file #32083)

Torsten Lilge <ttl>
Project Member
Thu 11 Sep 2014 09:44:37 PM UTC, comment #7: 

Exactly the same issue on WinXP

Again, characters like j g p q are truncated at the bottom.

In the history browser there are no grid lines, just alternating colors. Maybe that's an idea for the workspace as well?
Or, like Matlab (r2014b), no grid lines at all in the workspace?

Philip Nienhuis <philipnienhuis>
Project Member
Thu 11 Sep 2014 09:28:36 PM UTC, comment #6: 

Thanks for the picture; you seem to have a little bit larger fonts.

Apparently there's room for optimization as regards table row heights and font sizes.

I'll reboot into WinXP to see how it looks there (I rarely start that OS these days)

Philip Nienhuis <philipnienhuis>
Project Member
Thu 11 Sep 2014 08:25:51 PM UTC, comment #5: 

I just tried a different machine (WinXP) running lower resolution, I can see the same issue with underscores not shown.

So it must be dependent on system settings.

John Donoghue <lostbard>
Project Member
Thu 11 Sep 2014 08:15:23 PM UTC, comment #4: 

Picture attached

Looking at the code for the workspace, we set the heights of the table based on the font metrics.

I tried making my system fonts in Windows preferences smaller and it made the underscores closer to the line, but didn't cover them up, however it is probably based on screen resolution and a number of other things to what size the font used is.


John Donoghue <lostbard>
Project Member
Thu 11 Sep 2014 07:48:43 PM UTC, comment #3: 

Do you have a screenshot of what it looks like on your side?

In the history pane underscores do show up.

Perhaps the gridlines in the workspace are drawn AFTER the variable names and "overwrite" them.
Looking closer, it may be a mere question of adding a bit more space below variable names so that underscores and characters like "j", "p", "q" and "g" aren't cut off (one can that as well in the screenshot I supplied).

Philip Nienhuis <philipnienhuis>
Project Member
Thu 11 Sep 2014 03:55:13 PM UTC, comment #2: 

With new install of mxe-octave 32 and 64, it still shows ok for me.

Does it also show the same issue in the command history?

John Donoghue <lostbard>
Project Member
Thu 11 Sep 2014 03:30:42 PM UTC, comment #1: 

Works ok on my win 7 laptop, with 3.8.2, both 32 and 64 bit built a couple of weeks ago.

I'm rebuilding a current mxe 32 bit at the moment.

The grid lines on your workspace table look a lot smaller than mine do.

John Donoghue <lostbard>
Project Member
Thu 11 Sep 2014 01:51:32 PM UTC, original submission:  

See attached pic.
Underscores in variable/object/... names are not shown at all. In contrast, hyphens appear as expected.
Not a big deal, but it is confusing for unwary users.

FYI: Windows 7 64bit, Octave --enable-64

Just checked: same issue in Octave-4.1.0+ 32-bit

Philip Nienhuis <philipnienhuis>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32083:  bug43196_01.diff added by ttl (452B - text/x-diff)
file #32075:  workspace.jpg added by lostbard (108KiB - image/jpeg)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Updated the item)
  • -email is unavailable- added by lostbard (Posted a comment)
  • -email is unavailable- added by philipnienhuis (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-09-26 ttl StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
    2014-09-12 ttl Attached File- => Added bug43196_01.diff, #32083
        StatusNone => Patch Submitted
    2014-09-11 lostbard Attached File- => Added workspace.jpg, #32075
    2014-09-11 philipnienhuis Attached File- => Added wrksp_missing_underscore.png, #32063

    Back to the top


    Powered by Savane 3.5