bugGNU Octave - Bugs: bug #43140, setxor fails when one of the input...

 
 

bug #43140: setxor fails when one of the input sets is empty and more than one output argument is required

Submitter:  Julien Bect <jbect>
Submitted:  Thu 04 Sep 2014 07:49:55 AM UTC
   
 
Category:  Octave Function Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  * Closed
Release:  * 3.8.2 Operating System:  * GNU/Linux
Fixed Release:  None Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 24 Sep 2014 05:33:29 PM UTC, comment #5: 

It's a judgement call.  In general, we try to make the stable branch very stable.  Even a simple fix, such as this one, doesn't necessarily get backported if the impact of not fixing it is small.  This bug has been present since at least 3.2.4 and you are the first to notice it and report it.  This suggests that this code path isn't used very frequently.  In that case, I prefer to leave the stable branch alone and put the fix on the development branch.  On the other hand, if Octave computed 2+2 = 5 then that would require an immediate fix on the stable branch.

Rik <rik5>
Group administrator
Wed 24 Sep 2014 06:37:25 AM UTC, comment #4: 

Hello Rik,

Thanks for pushing the patch.

I have a question however: since this is a simple fix for a bug that affects the current (3.8.2) release, why not push it on the stable branch ?

@++
Julien

Julien Bect <jbect>
Wed 24 Sep 2014 04:06:59 AM UTC, comment #3: 

I applied your patch to the development branch here (http://hg.savannah.gnu.org/hgweb/octave/rev/d171e23cac81).  Closing report.

Rik <rik5>
Group administrator
Thu 04 Sep 2014 08:26:06 AM UTC, comment #2: 

Another version of the patch (simpler is better).

(file #32024)

Julien Bect <jbect>
Thu 04 Sep 2014 07:53:55 AM UTC, comment #1: 

Hop, here is a patch.

(file #32023)

Julien Bect <jbect>
Thu 04 Sep 2014 07:49:55 AM UTC, original submission:  

Function setxor fails when one of the input sets is empty and more than one output argument is required.


octave:1> [c, ia, ib] = setxor (1, [])
error: 'na' undefined near line 88 column 20
error: evaluating argument list element number 1
error: evaluating argument list element number 1
error: called from:
error:   /usr/share/octave/3.8.1/m/set/setxor.m at line 88, column 8


A patch will shortly follow.

@++
Julien

Julien Bect <jbect>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32024:  setxor_v2.patch added by jbect (2KiB - text/x-patch)
file #32023:  setxor.patch added by jbect (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jbect (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only group members can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-09-24 rik5 Item GroupSegfault, Bus Error, etc. Incorrect Result
        StatusNone Fixed
        Open/ClosedOpen Closed
    2014-09-04 jbect Attached File- Added setxor_v2.patch, #32024
    2014-09-04 jbect Attached File- Added setxor.patch, #32023

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code