bugGNU Octave - Bugs: bug #42839, gnulib fpieee module causes build...

 
 

bug #42839: gnulib fpieee module causes build failure on Alpha and SH systems

Submitted by:  Mike Miller <mtmiller>
Submitted on:  Thu 24 Jul 2014 11:54:35 PM UTC  
 
Category: Configuration and Build SystemSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Build Failure
Status: FixedAssigned to: None
Originator Name: Open/Closed: Closed
Release: 3.8.1Operating System: GNU/Linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 06 Aug 2014 02:04:49 AM UTC, comment #5:

Sure, I will follow up on this or with a new bug if any ideas or fixes come from the gnulib discussion.

Gnulib thread starts at http://lists.gnu.org/archive/html/bug-gnulib/2014-08/msg00006.html

Mike Miller <mtmiller>
Project Member
Mon 04 Aug 2014 08:13:36 PM UTC, comment #4:

@Mike: It seems like the Octave part of the fix is done. I'll let you close the report if you agree.

Rik <rik5>
Project Administrator
Mon 04 Aug 2014 03:54:47 PM UTC, comment #3:

Thomas: No, but I'll send something to the gnulib list later today.

Rik: The porter has verified that your change works on Alpha.

Here's a further wrinkle: I just discovered that Octave had been correctly handling -mieee on Alpha for years, see

http://hg.savannah.gnu.org/hgweb/octave/file/05a7c6026df0/configure.ac#l482

Since the logic in Octave does this correctly before gl_INIT is even called, a further workaround for this bug would be to just filter out -mieee or -ieee from CPPFLAGS entirely right after gl_INIT returns. I didn't look closely enough at the Debian build log, but it actually does have -mieee in both CFLAGS and CPPFLAGS, so gnulib adding it to CPPFLAGS is completely redundant.

Mike Miller <mtmiller>
Project Member
Mon 04 Aug 2014 11:31:44 AM UTC, comment #2:

Has this been forwarded to gnulib?

Thomas Weber <tweber>
Sat 26 Jul 2014 05:46:18 PM UTC, comment #1:

Amazing that anyone is still building on Alpha architectures.

jwe usually supports doing the right thing rather than the expedient thing. This would mean filing a bug report with the gnulib project. I would say that we could, in addition, put in a workaround to filter out '-mieee' from the CPPFLAGS that we pass to moc.

The moc command to use is defined in the Makefile.am in libgui. Look for "define moc-command"

I added a filter to Makefile.am along the lines of the one in libinterp/Makefile.am that is used for ULT_DIST_SRC

I checked it in on the stable branch (http://hg.savannah.gnu.org/hgweb/octave/rev/a5add7b660ac), but I have no way to verify it.

Rik <rik5>
Project Administrator
Thu 24 Jul 2014 11:54:35 PM UTC, original submission:

The fix for bug #42583 added a dependency on the gnulib "fpieee" module. This module causes the Octave build to fail on the Alpha and SH architectures. Originally reported as Debian bug 746924 [1].

The problem appears to be that the fpieee module adds a "-mieee" option to the compiler, which is needed to support strict IEEE floating point when compiling with GCC on these architectures. But the option is added to the CPPFLAGS variable, which is really supposed to be for preprocessor options only, typically -I and -D. The CPPFLAGS variable is given to the Qt moc tool, and moc errors because it doesn't know what to do with the "-mieee" option.

One option would be to work with gnulib to find a better way to handle this required compiler flag so that it doesn't show up in CPPFLAGS, where it really shouldn't be.

Another option would be to not pass CPPFLAGS to moc, or to filter the contents so it only contains the ones actually needed for moc to do its job.

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=746924

Mike Miller <mtmiller>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by tweber (Posted a comment)
  • -unavailable- added by rik5 (Posted a comment)
  • -unavailable- added by mtmiller (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 06 Aug 2014 02:04:49 AM UTCmtmillerOpen/ClosedOpen=>Closed
    Mon 04 Aug 2014 08:13:36 PM UTCrik5StatusReady For Test=>Fixed
    Sat 26 Jul 2014 05:46:18 PM UTCrik5StatusNone=>Ready For Test

    Back to the top


    Powered by Savane 3.1-cleanup