bugGNU Octave - Bugs: bug #41823, GUI: editor menu not updated in...

 
 

bug #41823: GUI: editor menu not updated in mac menu bar

Submitted by:  Pantxo Diribarne <pantxo>
Submitted on:  Mon 10 Mar 2014 05:50:23 PM UTC  
 
Category:  GUI Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  Mac OS

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Tue 11 Mar 2014 09:24:11 AM UTC, comment #6: 

I think as a long term solution, a shared menu bar, with some actions disabled depending on the window which has focus, would be cleaner than multiple menus.
After all, the editor menu already shares a bunch of common actions with the main menu. AFAICS this is the way spyder [1] works and it's pretty intuitive.

[1] http://code.google.com/p/spyderlib/wiki/Screenshots

Pantxo Diribarne <pantxo>
Project Member
Tue 11 Mar 2014 07:07:52 AM UTC, comment #5: 

Thanks for the patch. I have pushed it with changeset
http://hg.savannah.gnu.org/hgweb/octave/rev/bfb735b70978

I tried to fix it with a shared menu bar (QMenuBar(0)) as mentioned in the qt docs (http://qt-project.org/doc/qt-4.8/qmenubar.html#qmenubar-on-mac-os-x) but then the global menu bar (at least on my ubuntu system) always shows the editor menu even when the main window has focus.

Torsten Lilge <ttl>
Project Member
Mon 10 Mar 2014 11:24:13 PM UTC, comment #4: 

The attached patch fixes the issue by forcing a non native menu bar attached to the editor.
The main window menu is still native and it works whether the editor is docked or not.

(file #30852)

Pantxo Diribarne <pantxo>
Project Member
Mon 10 Mar 2014 07:30:24 PM UTC, comment #3: 

Just a precision: in the editor, I can "go to line" using CMD+g.
The menu item is not visible, but the shortcut works as expected in the editor context.

Pantxo Diribarne <pantxo>
Project Member
Mon 10 Mar 2014 07:00:51 PM UTC, comment #2: 

This is true at least for the current dev 4.1.0+, and 3.8.0 release (octave-forge dmg).

Pantxo Diribarne <pantxo>
Project Member
Mon 10 Mar 2014 06:47:09 PM UTC, comment #1: 

Does this mean that the editor never had a menu bar on MAC OS?

Torsten Lilge <ttl>
Project Member
Mon 10 Mar 2014 05:50:23 PM UTC, original submission:  

Mac has only one menu per application. I don't know how this menu should behave when, as in octave's editor, there are widget specific menus.

I would expect the main menu to be updated when the editor has focus, but this is not what I observe: whether the editor is docked or not, the main menu doesn't show editor specific item such as "toggle break point" or "go to line". I can only access the functionalities that have a push button on the toolbar (i.e. "toggle break point" but not "go to line").

Pantxo Diribarne <pantxo>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30852:  macmenubar_bug41823.patch added by pantxo (898B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ttl (Posted a comment)
  • -email is unavailable- added by pantxo (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-03-11 ttl StatusNone => Fixed
        Open/ClosedOpen => Closed
    2014-03-10 pantxo Attached File- => Added macmenubar_bug41823.patch, #30852

    Back to the top


    Powered by Savane 3.5