bugGNU Octave - Bugs: bug #41802, Fix rcond returning uninitialised...

 
 

bug #41802: Fix rcond returning uninitialised value

Submitted by:  PrasannaKumar Muralidharan <prasannatsm>
Submitted on:  Fri 07 Mar 2014 04:09:11 PM UTC  
 
Category:  Libraries Severity:  3 - Normal
Priority:  5 - Normal Item Group:  Incorrect Result
Status:  Fixed Assigned to:  None
Originator Name:  Open/Closed:  Closed
Release:  dev Operating System:  Any

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Mon 07 Apr 2014 10:14:29 AM UTC, comment #7: 

Did not spend time in doing this for long. Sorry.

Anyway will try to write test case. Thanks :).

PrasannaKumar Muralidharan <prasannatsm>
Sun 06 Apr 2014 09:27:43 PM UTC, comment #6: 

I went ahead and changed the initialization value to Octave_NaN and committed your patch here (http://hg.savannah.gnu.org/hgweb/octave/rev/cb37b17b6091).  Closing report.

Rik <rik5>
Project Administrator
Fri 14 Mar 2014 04:11:35 PM UTC, comment #5: 

Okay I will change it to Octave_NaN.

I have not written any test case for Octave so far. I will give it a try.

PrasannaKumar Muralidharan <prasannatsm>
Thu 13 Mar 2014 11:01:08 PM UTC, comment #4: 

I think it might be better to initialize with Octave_NaN.  A return value of Octave_Inf would imply that the calculation succeeded, but that the result was Inf.  A return value of NaN usually indicates a major failure.

Second, it's not required but it would be nice to demonstrate a test case where this matters.

Rik <rik5>
Project Administrator
Fri 07 Mar 2014 05:47:11 PM UTC, comment #3: 

Messed up folding. So created a new patch and attached it here. Please have a look at it.

(file #30823)

PrasannaKumar Muralidharan <prasannatsm>
Fri 07 Mar 2014 04:41:25 PM UTC, comment #2: 

Can you please fold all of these patches into one? Enable the histedit
extension and do

hg histedit -r PRASANNAKUMARS_STARTING_REVISION

then in the plan that shows up in your text editor, pick "fold" for the
relevant patches.

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Fri 07 Mar 2014 04:39:25 PM UTC, comment #1: 

Can you please fold all of these patches into one? Enable the histedit extension and do

Jordi GutiƩrrez Hermoso <jordigh>
Project Administrator
Fri 07 Mar 2014 04:09:11 PM UTC, original submission:  

rcond() function was returning uninitialised values in some error condition. Initialised the value to octave_Inf.

Questions:
1. Is returning octave_Inf correct in this case? If not what is the correct return value?
2. Is there a need to add test cases for rcond that check failure cases also?

PrasannaKumar Muralidharan <prasannatsm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #30823:  fix_uninitialised_return_values.diff added by prasannatsm (2KiB - text/x-patch - Patch fixing return of uninitialised values)
file #30818:  fix_uninitialised_return_in_dMatrixcc.diff added by prasannatsm (771B - text/x-patch - Added 4 patches fixing the same issue in different files)
file #30819:  fix_uninitialised_return_in_fMatrixcc.diff added by prasannatsm (778B - text/x-patch - Added 4 patches fixing the same issue in different files)
file #30820:  fix_uninitialised_return_in_CMatrixcc.diff added by prasannatsm (785B - text/x-patch - Added 4 patches fixing the same issue in different files)
file #30821:  fix_uninitialised_return_in_fCMatrixcc.diff added by prasannatsm (798B - text/x-patch - Added 4 patches fixing the same issue in different files)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rik5 (Posted a comment)
  • -email is unavailable- added by jordigh (Posted a comment)
  • -email is unavailable- added by prasannatsm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only project members can vote.

     

     

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-04-06 rik5 StatusPatch Submitted => Fixed
        Open/ClosedOpen => Closed
        SummaryFix returning uninitialised value => Fix rcond returning uninitialised value
    2014-03-07 prasannatsm Attached File- => Added fix_uninitialised_return_values.diff, #30823
    2014-03-07 jordigh StatusNone => Patch Submitted
    2014-03-07 prasannatsm Attached File- => Added fix_uninitialised_return_in_dMatrixcc.diff, #30818
        Attached File- => Added fix_uninitialised_return_in_fMatrixcc.diff, #30819
        Attached File- => Added fix_uninitialised_return_in_CMatrixcc.diff, #30820
        Attached File- => Added fix_uninitialised_return_in_fCMatrixcc.diff, #30821

    Back to the top


    Powered by Savane 3.5